Merge pull request #1888 from NativeScript/bektchiev/fix-create-file

Ensure parent directory when creating a new file
This commit is contained in:
Vladimir Enchev
2016-04-14 15:35:24 +03:00
3 changed files with 16 additions and 4 deletions

View File

@ -638,4 +638,14 @@ export function test_UnlockAfterWrite(done) {
return file.remove();
}).then(() => done())
.catch(done);
}
export function test_CreateParentOnNewFile(done) {
var documentsFolderName = fs.knownFolders.documents().path;
var tempFileName = fs.path.join(documentsFolderName, "folder1", "folder2", "Test_File_Create_Parent.txt");
var file = fs.File.fromPath(tempFileName);
file.writeText("Hello World!").then(() => {
return fs.knownFolders.documents().getFolder("folder1").remove();
}).then(() => done())
.catch(done);
}

View File

@ -327,6 +327,7 @@ export class FileSystemAccess {
if (isFolder) {
created = javaFile.mkdirs();
} else {
javaFile.getParentFile().mkdirs();
created = javaFile.createNewFile();
}

View File

@ -52,11 +52,12 @@ export class FileSystemAccess {
var exists = fileManager.fileExistsAtPath(path);
if (!exists) {
if (!fileManager.createFileAtPathContentsAttributes(path, null, null)) {
var parentPath = this.getParent(path, onError).path;
if (!fileManager.createDirectoryAtPathWithIntermediateDirectoriesAttributesError(parentPath, true, null) ||
!fileManager.createFileAtPathContentsAttributes(path, null, null)) {
if (onError) {
onError(new Error("Failed to create folder at path '" + path + "'"));
onError(new Error("Failed to create file at path '" + path + "'"));
}
return undefined;
}
}
@ -406,4 +407,4 @@ export class FileSystemAccess {
var nsString = NSString.stringWithString(NSString.pathWithComponents(nsArray));
return nsString.stringByStandardizingPath;
}
}
}