javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-26 03:01:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix: binding to event does not work if there are other properties set in XML after the event binding

Browse Source
This commit is contained in:
vakrilov
2015-03-05 18:28:05 +02:00
parent 9056482ddb
commit d699fea65f
1 changed files with 18 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
ui/builder/component-builder.ts
View File

@ -74,19 +74,7 @@ export function getComponentModule(elementName: string, namespace: string, attri
if (isBinding(attrValue) && instance.bind) {
if (isKnownEvent(attr, instanceModule)) {
// Get the event handler from instance.bindingContext.
var propertyChangeHandler = (args: observable.PropertyChangeData) => {
if (args.propertyName === "bindingContext") {
var handler = instance.bindingContext && instance.bindingContext[getBindingExpressionFromAttribute(attrValue)];
// Check if the handler is function and add it to the instance for specified event name.
if (types.isFunction(handler)) {
instance.on(attr, handler, instance.bindingContext);
}
instance.off(observable.knownEvents.propertyChange, propertyChangeHandler);
}
};
instance.on(observable.knownEvents.propertyChange, propertyChangeHandler);
attachEventBinding(instance, attr, attrValue);
} else {
instance.bind(getBinding(instance, attr, attrValue));
}
@ -147,6 +135,23 @@ export function getComponentModule(elementName: string, namespace: string, attri
return componentModule;
}
function attachEventBinding(instance: view.View, eventName: string, value:string) {
// Get the event handler from instance.bindingContext.
var propertyChangeHandler = (args: observable.PropertyChangeData) => {
if (args.propertyName === "bindingContext") {
var handler = instance.bindingContext && instance.bindingContext[getBindingExpressionFromAttribute(value)];
// Check if the handler is function and add it to the instance for specified event name.
if (types.isFunction(handler)) {
instance.on(eventName, handler, instance.bindingContext);
}
instance.off(observable.knownEvents.propertyChange, propertyChangeHandler);
}
};
instance.on(observable.knownEvents.propertyChange, propertyChangeHandler);
}
function isGesture(name: string, instance: any): boolean {
return gestures.fromString(name.toLowerCase()) !== undefined;
}