javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-18 05:18:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed: Exit transition on API Level 23 with cachePagesOnNavigate=true

Browse Source 
When we are on API Level 23 and we have cachePagesOnNavigate=true, the exit transition of the current (disappearing) page ends immediately after its start, which in turn removes the page UI from the fragment and leaves a white spot in place of the current page while the enter transition of the new page is being played.

Related to #2225
This commit is contained in:
Rossen Hristov
2016-06-07 11:50:35 +03:00
parent 95b521e53b
commit d1c7eacaac
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tns-core-modules/ui/transition/transition.android.ts
View File

@ -1,5 +1,5 @@
import { Transition as definitionTransition } from "ui/transition"; import { Transition as definitionTransition } from "ui/transition";
import { NavigationTransition, BackstackEntry } from "ui/frame"; import { NavigationTransition, BackstackEntry, topmost } from "ui/frame";
import { Page} from "ui/page"; import { Page} from "ui/page";
import { getClass } from "utils/types"; import { getClass } from "utils/types";
import { device } from "platform"; import { device } from "platform";
@ -122,6 +122,15 @@ export function _setAndroidFragmentTransitions(navigationTransition: NavigationT
} }
let useLollipopTransition = name && (name.indexOf("slide") === 0 || name === "fade" || name === "explode") && _sdkVersion() >= 21; let useLollipopTransition = name && (name.indexOf("slide") === 0 || name === "fade" || name === "explode") && _sdkVersion() >= 21;
// There is a problem when we have cachePagesOnNavigate on API Level 23 only.
// The exit transition of the current fragment ends immediately, the page UI is removed from the visual tree
// and a white spot is left in its place making the transition ugly.
// So we will use the "old" pre-Lollipop transitions in this particular case.
if (topmost().android.cachePagesOnNavigate && _sdkVersion() === 23){
useLollipopTransition = false;
}
if (useLollipopTransition) { if (useLollipopTransition) {
// setEnterTransition: Enter // setEnterTransition: Enter
// setExitTransition: Exit // setExitTransition: Exit