javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-17 12:57:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: sourceMap improvements

Browse Source
This commit is contained in:
Igor Randjelovic
2021-04-12 12:51:41 +02:00
parent 482b7b11f6
commit cfd98d3674
3 changed files with 45 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
packages/webpack5/src/configuration/base.ts
View File

@ -1,4 +1,4 @@
import {
import webpack, {
ContextExclusionPlugin,
DefinePlugin,
HotModuleReplacementPlugin,
@ -44,8 +44,30 @@ export default function (config: Config, env: IWebpackEnv = _env): Config {
// resolved at runtime
config.externals(['package.json', '~/package.json']);
// todo: devtool
config.devtool('inline-source-map');
const getSourceMapType = (map: string | boolean): Config.DevTool => {
const defaultSourceMap = 'inline-source-map';
if (typeof map === 'undefined') {
// source-maps disabled in production by default
// enabled with --env.sourceMap=<type>
if (mode === 'production') {
// todo: we may set up SourceMapDevToolPlugin to generate external maps in production
return false;
}
return defaultSourceMap;
}
// when --env.sourceMap=true is passed, use default
if (typeof map === 'boolean' && map) {
return defaultSourceMap;
}
// pass any type of sourceMap with --env.sourceMap=<type>
return map as Config.DevTool;
};
config.devtool(getSourceMapType(env.sourceMap));
// todo: figure out easiest way to make "node" target work in ns
// rather than the custom ns target implementation that's hard to maintain