javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix-next(HMR): apply changes in page styles at runtime when app root is a frame

Browse Source
This commit is contained in:
Vasil Chimev
2019-05-03 13:26:37 +03:00
parent b7abb3dd64
commit cfa37cfa28
4 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tns-core-modules/ui/frame/frame.android.ts
View File

@@ -349,6 +349,11 @@ export class Frame extends FrameBase {
}
if (context && context.type && context.path) {
// Handle local styls changes when app root is Frame
if (context.type === ModuleType.style) {
return this._changeLocalStyles(context.path);
}
// Set NavigationType.replace for HMR.
this.navigationType = NavigationType.replace;
const currentBackstackEntry = this._currentEntry;

6
tns-core-modules/ui/frame/frame.ios.ts
View File

@@ -3,6 +3,7 @@ import {
iOSFrame as iOSFrameDefinition, BackstackEntry, NavigationTransition
} from ".";
import { Page } from "../page";
import { ModuleType } from "../../ui/core/view/view-common";
import { profile } from "../../profiling";
//Types.
@@ -73,6 +74,11 @@ export class Frame extends FrameBase {
}
if (context && context.type && context.path) {
// Handle local styls changes when app root is Frame
if (context.type === ModuleType.style) {
return this._changeLocalStyles(context.path);
}
// Set NavigationType.replace for HMR.
// When `viewDidAppear()` set to NavigationType.forward.
this.navigationType = NavigationType.replace;