Merge pull request #1191 from NativeScript/hdeshev/bom-check

Check for UTF-8 BOM's in package.json files

application/package.json

@@ -1,2 +1,2 @@
-{ "name" : "application",
+{ "name" : "application",
   "main" : "application.js" }

apps/absolute-layout-demo/package.json

@@ -1,2 +1,2 @@
-{ "name" : "absolute-layout-demo",
+{ "name" : "absolute-layout-demo",
   "main" : "app.js" }

apps/cuteness.io/package.json

@@ -1,2 +1,2 @@
-{ "name" : "testsapp",
+{ "name" : "testsapp",
   "main" : "app.js" }

apps/editable-text-demo/package.json

@@ -1,2 +1,2 @@
-{ "name" : "editable-text-demo",
+{ "name" : "editable-text-demo",
   "main" : "app.js" }

apps/gallery-app/package.json

@@ -1,2 +1,2 @@
-{ "name" : "gallery-app",
+{ "name" : "gallery-app",
   "main" : "app.js" }

apps/modal-views-demo/package.json

@@ -1,2 +1,2 @@
-{ "name" : "modal-views-demo",
+{ "name" : "modal-views-demo",
   "main" : "app.js" }

apps/paylocity/package.json

@@ -1,4 +1,4 @@
-{
+{
 	"name" : "testsapp",
 	"main" : "app.js"
 }

apps/perf-tests/ApplicationLoadTimeAndFPS/package.json

@@ -1,2 +1,2 @@
-{ "name" : "ApplicationLoadTimeAndFPS",
+{ "name" : "ApplicationLoadTimeAndFPS",
   "main" : "app.js" }

apps/perf-tests/ApplicationSize/package.json

@@ -1,2 +1,2 @@
-{ "name" : "ApplicationSize",
+{ "name" : "ApplicationSize",
   "main" : "app.js" }

apps/perf-tests/ComplexObjectGraphMemoryTest/package.json

@@ -1,2 +1,2 @@
-{ "name" : "ComplexObjectGraphMemoryTest",
+{ "name" : "ComplexObjectGraphMemoryTest",
   "main" : "app.js" }

apps/perf-tests/ControlCreationSpeedTest/package.json

@@ -1,2 +1,2 @@
-{ "name" : "ControlCreationSpeedTest",
+{ "name" : "ControlCreationSpeedTest",
   "main" : "app.js" }

apps/perf-tests/LargeObjectArrayMemoryLeakTest/package.json

@@ -1,2 +1,2 @@
-{ "name" : "LargeObjectArrayMemoryLeakTest",
+{ "name" : "LargeObjectArrayMemoryLeakTest",
   "main" : "app.js" }

apps/perf-tests/LargeObjectArrayMemoryTest/package.json

@@ -1,2 +1,2 @@
-{ "name" : "LargeObjectArrayMemoryTest",
+{ "name" : "LargeObjectArrayMemoryTest",
   "main" : "app.js" }

apps/perf-tests/NavigationMemoryLeakTest/package.json

@@ -1,2 +1,2 @@
-{ "name" : "NavigationMemoryLeakTest",
+{ "name" : "NavigationMemoryLeakTest",
   "main" : "app.js" }

apps/perf-tests/NavigationTest/package.json

@@ -1,2 +1,2 @@
-{ "name" : "NavigationTest",
+{ "name" : "NavigationTest",
   "main" : "app.js" }

apps/perf-tests/SingleUIObjectMemoryLeakTest/package.json

@@ -1,2 +1,2 @@
-{ "name" : "SingleUIObjectMemoryLeakTest",
+{ "name" : "SingleUIObjectMemoryLeakTest",
   "main" : "app.js" }

apps/perf-tests/SpeedTests/package.json

@@ -1,2 +1,2 @@
-{ "name" : "SpeedTests",
+{ "name" : "SpeedTests",
   "main" : "app.js" }

apps/perf-tests/package.json

@@ -1,4 +1,4 @@
-{
+{
     "name" : "Performance Tests",
     "main" : "./ApplicationSize/app.js"
 }

apps/pickers-demo/package.json

@@ -1,2 +1,2 @@
-{ "name" : "pickers-demo",
+{ "name" : "pickers-demo",
   "main" : "app.js" }

apps/placeholder-demo/package.json

@@ -1,2 +1,2 @@
-{ "name" : "template-hello-world",
+{ "name" : "template-hello-world",
   "main" : "app.js" }

apps/tab-view-demo/package.json

@@ -1,2 +1,2 @@
-{ "name" : "tab-view-demo",
+{ "name" : "tab-view-demo",
   "main" : "app.js" }

apps/template-blank/package.json

@@ -1,2 +1,2 @@
-{ "name" : "template-blank-app",
+{ "name" : "template-blank-app",
   "main" : "app.js" }

apps/template-hello-world/package.json

@@ -1,2 +1,2 @@
-{ "name" : "template-hello-world",
+{ "name" : "template-hello-world",
   "main" : "app.js" }

apps/template-master-detail/package.json

@@ -1,2 +1,2 @@
-{ "name" : "template-master-detail",
+{ "name" : "template-master-detail",
   "main" : "app.js" }

apps/template-settings/package.json

@@ -1,2 +1,2 @@
-{ "name" : "template-settings",
+{ "name" : "template-settings",
   "main" : "app.js" }

apps/template-tab-navigation/package.json

@@ -1,2 +1,2 @@
-{ "name" : "template-tab-navigation",
+{ "name" : "template-tab-navigation",
   "main" : "app.js" }

apps/tests/app/package.json

@@ -1,2 +1,2 @@
-{ "name" : "testsapp",
+{ "name" : "testsapp",
   "main" : "app.js" }

apps/tests/package.json

@@ -1,2 +1,2 @@
-{ "name" : "Tests",
+{ "name" : "Tests",
   "main" : "app/app.js" }

apps/tests/pages/package.json

@@ -1,2 +1,2 @@
-{ "name" : "testsapp",
+{ "name" : "testsapp",
   "main" : "app.js" }

apps/tests/styling/package.json

@@ -1,2 +1,2 @@
-{ "name" : "styling",
+{ "name" : "styling",
   "main" : "app.js" }

apps/tests/xml-declaration/mymodule/package.json

@@ -1,2 +1,2 @@
-{ "name" : "MyControl",
+{ "name" : "MyControl",
   "main" : "MyControl.js" }

apps/tests/xml-declaration/mymodulewithxml/package.json

@@ -1,2 +1,2 @@
-{ "name" : "MyControl",
+{ "name" : "MyControl",
   "main" : "MyControl.js" }

apps/tests/xml-declaration/package.json

@@ -1,2 +1,2 @@
-{ "name" : "xml-declaration",
+{ "name" : "xml-declaration",
   "main" : "app.js" }

apps/ui-tests-app/package.json

@@ -1,2 +1,2 @@
-{ "name" : "ui-tests-app",
+{ "name" : "ui-tests-app",
   "main" : "app.js" }

apps/web-view-demo/package.json

@@ -1,2 +1,2 @@
-{ "name" : "web-view-demo",
+{ "name" : "web-view-demo",
   "main" : "app.js" }

apps/wrap-layout-demo/package.json

@@ -1,2 +1,2 @@
-{ "name" : "wrap-layout-demo",
+{ "name" : "wrap-layout-demo",
   "main" : "app.js" }

apps/xml-demo/package.json

@@ -1,2 +1,2 @@
-{ "name" : "xml-demo",
+{ "name" : "xml-demo",
   "main" : "app.js" }

camera/package.json

@@ -1,2 +1,2 @@
-{ "name" : "camera",
+{ "name" : "camera",
   "main" : "camera.js" }

color/package.json

@@ -1,2 +1,2 @@
-{ "name" : "color",
+{ "name" : "color",
   "main" : "color.js" }

console/package.json

@@ -1,2 +1,2 @@
-{ "name" : "console",
+{ "name" : "console",
   "main" : "console.js" }

data/observable-array/package.json

@@ -1,4 +1,4 @@
-{
+{
 	"name" : "observable-array",
 	"main" : "observable-array.js"
 }

data/observable/package.json

@@ -1,4 +1,4 @@
-{ 
+{ 
   "name" : "observable",
   "main" : "observable.js"
 }

data/virtual-array/package.json

@@ -1,4 +1,4 @@
-{
+{
 	"name" : "virtual-array",
 	"main" : "virtual-array.js"
 }

file-system/package.json

@@ -1,2 +1,2 @@
-{ "name" : "file-system",
+{ "name" : "file-system",
   "main" : "file-system.js" }

fps-meter/package.json

@@ -1,2 +1,2 @@
-{ "name" : "fps-meter",
+{ "name" : "fps-meter",
   "main" : "fps-meter.js" }

globals/package.json

@@ -1,2 +1,2 @@
-{ "name" : "globals",
+{ "name" : "globals",
   "main" : "globals.js" }

gruntfile.js

@@ -422,16 +422,6 @@ module.exports = function(grunt) {
                 NODE_PATH: localCfg.outModulesDir,
             }
         },
-        bom: {
-            allTargetFiles: {
-                src: [
-                    pathModule.join(localCfg.outDir, "**/*.ts"),
-                    pathModule.join(localCfg.outDir, "**/*.js"),
-                    pathModule.join(localCfg.outDir, "**/*.css"),
-                    pathModule.join(localCfg.outDir, "**/*.xml")
-                    ]
-            }
-        },
         typedoc: {
             build: {
                 options: {
@@ -463,7 +453,6 @@ module.exports = function(grunt) {
     grunt.loadNpmTasks("grunt-shell");
     grunt.loadNpmTasks("grunt-env");
     grunt.loadNpmTasks("grunt-simple-mocha");
-    grunt.loadNpmTasks('grunt-bom-removal');
     grunt.loadNpmTasks('grunt-typedoc');
 
     var cloneTasks = function(originalTasks, taskNameSuffix) {
@@ -564,6 +553,25 @@ module.exports = function(grunt) {
             "copy:readyAppFiles",
             "clean:readyAppFiles"
     ]);
+    grunt.registerTask("check-packagejson-boms", function() {
+        function hasBOM(filepath) {
+            var buf = grunt.file.read(filepath, { encoding: null });
+            return (buf[0] === 0xEF && buf[1] === 0xBB && buf[2] === 0xBF);
+        }
+        var packageDescriptors = grunt.file.expand({}, [
+            '**/package.json',
+            '!node_modules/**'
+        ]);
+        var errors = packageDescriptors.map(function(packagePath) {
+            if (hasBOM(packagePath)) {
+                return "File " + packagePath + " contains a UTF-8 BOM.";
+            } else {
+                return null;
+            }
+        }).filter(function(errorMessage) { return !!errorMessage; });
+        if (errors.length > 0)
+            grunt.fail.fatal("\n" + errors.join("\n"));
+    });
     grunt.registerTask("distribute-ts-apps-files", [
             "copy:readyTsAppFiles"
     ]);
@@ -606,8 +614,8 @@ module.exports = function(grunt) {
     grunt.registerTask("compile-modules", [
         "clean:build",
         "shell:getGitSHA",
+        "check-packagejson-boms",
         "compile-ts",
-        "bom:allTargetFiles",
         "collect-modules-raw-files",
         "copy:modulesPackageDef",
         "copy:definitionFiles",

http/package.json

@@ -1,2 +1,2 @@
-{ "name" : "http",
+{ "name" : "http",
   "main" : "http.js" }

image-source/package.json

@@ -1,2 +1,2 @@
-{ "name" : "image-source",
+{ "name" : "image-source",
   "main" : "image-source.js" }

location/package.json

@@ -1,2 +1,2 @@
-{ "name" : "location",
+{ "name" : "location",
   "main" : "location.js" }

package.json

@@ -18,7 +18,6 @@
     "shelljs": "0.5.3",
     "chai": "3.2.0",
     "grunt": "0.4.5",
-    "grunt-bom-removal": "0.2.0",
     "grunt-contrib-clean": "0.6.0",
     "grunt-contrib-copy": "git+https://github.com/ErjanGavalji/grunt-contrib-copy.git#1c976a133210be4ce8c96313f5daf14833f7f8f9",
     "grunt-env": "0.4.4",

platform/package.json

@@ -1,2 +1,2 @@
-{ "name" : "platform",
+{ "name" : "platform",
   "main" : "platform.js" }

text/package.json

@@ -1,2 +1,2 @@
-{ "name" : "text",
+{ "name" : "text",
   "main" : "text.js" }

timer/package.json

@@ -1,2 +1,2 @@
-{ "name" : "timer",
+{ "name" : "timer",
   "main" : "timer.js" }

trace/package.json

@@ -1,2 +1,2 @@
-{ "name" : "trace",
+{ "name" : "trace",
   "main" : "trace.js" }

ui/activity-indicator/package.json

@@ -1,2 +1,2 @@
-{ "name" : "activity-indicator",
+{ "name" : "activity-indicator",
   "main" : "activity-indicator.js" }

ui/border/package.json

@@ -1,2 +1,2 @@
-{ "name" : "border",
+{ "name" : "border",
   "main" : "border.js" }

ui/builder/package.json

@@ -1,2 +1,2 @@
-{ "name" : "builder",
+{ "name" : "builder",
   "main" : "builder.js" }

ui/button/package.json

@@ -1,2 +1,2 @@
-{ "name" : "button",
+{ "name" : "button",
   "main" : "button.js" }

ui/content-view/package.json

@@ -1,2 +1,2 @@
-{ "name" : "content-view",
+{ "name" : "content-view",
   "main" : "content-view.js" }

ui/date-picker/package.json

@@ -1,2 +1,2 @@
-{ "name" : "date-picker",
+{ "name" : "date-picker",
   "main" : "date-picker.js" }

ui/dialogs/package.json

@@ -1,2 +1,2 @@
-{ "name" : "dialogs",
+{ "name" : "dialogs",
   "main" : "dialogs.js" }

ui/editable-text-base/package.json

@@ -1,2 +1,2 @@
-{ "name" : "editable-text-base",
+{ "name" : "editable-text-base",
   "main" : "editable-text-base.js" }

ui/enums/package.json

@@ -1,2 +1,2 @@
-{ "name" : "enums",
+{ "name" : "enums",
   "main" : "enums.js" }

ui/frame/package.json

@@ -1,2 +1,2 @@
-{ "name" : "frame",
+{ "name" : "frame",
   "main" : "frame.js" }

ui/gestures/package.json

@@ -1,2 +1,2 @@
-{ "name" : "gestures",
+{ "name" : "gestures",
   "main" : "gestures.js" }

ui/html-view/package.json

@@ -1,2 +1,2 @@
-{ "name" : "html-view",
+{ "name" : "html-view",
   "main" : "html-view.js" }

ui/image-cache/package.json

@@ -1,2 +1,2 @@
-{ "name" : "image-cache",
+{ "name" : "image-cache",
   "main" : "image-cache.js" }

ui/image/package.json

@@ -1,2 +1,2 @@
-{ "name" : "image",
+{ "name" : "image",
   "main" : "image.js" }

ui/label/package.json

@@ -1,2 +1,2 @@
-{ "name" : "label",
+{ "name" : "label",
   "main" : "label.js" }

ui/layouts/absolute-layout/package.json

@@ -1,2 +1,2 @@
-{ "name" : "absolute-layout",
+{ "name" : "absolute-layout",
   "main" : "absolute-layout.js" }

ui/layouts/dock-layout/package.json

@@ -1,2 +1,2 @@
-{ "name" : "dock-layout",
+{ "name" : "dock-layout",
   "main" : "dock-layout.js" }

ui/layouts/grid-layout/package.json

@@ -1,2 +1,2 @@
-{ "name" : "grid-layout",
+{ "name" : "grid-layout",
   "main" : "grid-layout.js" }

ui/layouts/stack-layout/package.json

@@ -1,2 +1,2 @@
-{ "name" : "stack-layout",
+{ "name" : "stack-layout",
   "main" : "stack-layout.js" }

ui/layouts/wrap-layout/package.json

@@ -1,2 +1,2 @@
-{ "name" : "wrap-layout",
+{ "name" : "wrap-layout",
   "main" : "wrap-layout.js" }

ui/list-picker/package.json

@@ -1,2 +1,2 @@
-{ "name" : "list-picker",
+{ "name" : "list-picker",
   "main" : "list-picker.js" }

ui/list-view/package.json

@@ -1,2 +1,2 @@
-{ "name" : "list-view",
+{ "name" : "list-view",
   "main" : "list-view.js" }

ui/page/package.json

@@ -1,2 +1,2 @@
-{ "name" : "page",
+{ "name" : "page",
   "main" : "page.js" }

ui/placeholder/package.json

@@ -1,2 +1,2 @@
-{ "name" : "placeholder",
+{ "name" : "placeholder",
   "main" : "placeholder.js" }

ui/progress/package.json

@@ -1,2 +1,2 @@
-{ "name" : "progress",
+{ "name" : "progress",
   "main" : "progress.js" }

ui/scroll-view/package.json

@@ -1,2 +1,2 @@
-{ "name" : "scroll-view",
+{ "name" : "scroll-view",
   "main" : "scroll-view.js" }

ui/search-bar/package.json

@@ -1,2 +1,2 @@
-{ "name" : "search-bar",
+{ "name" : "search-bar",
   "main" : "search-bar.js" }

ui/segmented-bar/package.json

@@ -1,2 +1,2 @@
-{ "name" : "segmented-bar",
+{ "name" : "segmented-bar",
   "main" : "segmented-bar.js" }

ui/slider/package.json

@@ -1,2 +1,2 @@
-{ "name" : "slider",
+{ "name" : "slider",
   "main" : "slider.js" }

ui/styling/package.json

@@ -1,2 +1,2 @@
-{ "name" : "styling",
+{ "name" : "styling",
   "main" : "styling.js" }

ui/switch/package.json

@@ -1,2 +1,2 @@
-{ "name" : "switch",
+{ "name" : "switch",
   "main" : "switch.js" }

ui/tab-view/package.json

@@ -1,2 +1,2 @@
-{ "name" : "ui/tab-view",
+{ "name" : "ui/tab-view",
   "main" : "tab-view.js" }

ui/text-base/package.json

@@ -1,2 +1,2 @@
-{ "name" : "text-base",
+{ "name" : "text-base",
   "main" : "text-base.js" }

ui/text-field/package.json

@@ -1,2 +1,2 @@
-{ "name" : "text-field",
+{ "name" : "text-field",
   "main" : "text-field.js" }

ui/text-view/package.json

@@ -1,2 +1,2 @@
-{ "name" : "text-view",
+{ "name" : "text-view",
   "main" : "text-view.js" }

ui/time-picker/package.json

@@ -1,2 +1,2 @@
-{ "name" : "time-picker",
+{ "name" : "time-picker",
   "main" : "time-picker.js" }

ui/web-view/package.json

@@ -1,2 +1,2 @@
-{ "name" : "web-view",
+{ "name" : "web-view",
   "main" : "web-view.js" }