javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 02:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(android): potential navigation crash (#9996)

Browse Source
This commit is contained in:
Douglas Machado
2022-08-19 22:59:47 -03:00
committed by GitHub
parent 4b0c812707
commit ca3d9bdc13
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/core/ui/frame/fragment.transitions.android.ts
View File

@ -672,14 +672,19 @@ function transitionOrAnimationCompleted(entry: ExpandedEntry, backEntry: Backsta
entries.delete(entry); entries.delete(entry);
if (entries.size === 0) { if (entries.size === 0) {
const frame = entry.resolvedPage.frame;
// We have 0 or 1 entry per frameId in completedEntries // We have 0 or 1 entry per frameId in completedEntries
// So there is no need to make it to Set like waitingQueue // So there is no need to make it to Set like waitingQueue
const previousCompletedAnimationEntry = completedEntries.get(frameId); const previousCompletedAnimationEntry = completedEntries.get(frameId);
completedEntries.delete(frameId); completedEntries.delete(frameId);
waitingQueue.delete(frameId); waitingQueue.delete(frameId);
if (!entry.resolvedPage) {
if (Trace.isEnabled()) {
Trace.write(`Transition completed - Entry ${entry} with unexpected null value for the resolvedPage property.`, Trace.categories.Transition, Trace.messageType.error);
}
return;
}
const frame = entry.resolvedPage.frame;
const navigationContext = frame._executingContext || { const navigationContext = frame._executingContext || {
navigationType: NavigationType.back, navigationType: NavigationType.back,
}; };