javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 19:26:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(tabs-android): wrong tabStripItem selected (#7522)

Browse Source
This commit is contained in:
Alexander Djenkov
2019-07-16 10:18:01 +03:00
committed by GitHub
parent 16924f4112
commit ca22ba9391
2 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tns-core-modules-widgets/android/widgets/src/main/java/org/nativescript/widgets/TabLayout.java
View File

@ -383,7 +383,11 @@ public class TabLayout extends HorizontalScrollView {
} }
int prevPosition = mTabStrip.getSelectedPosition(); int prevPosition = mTabStrip.getSelectedPosition();
onSelectedPositionChange(position, prevPosition);
if (prevPosition != position) {
onSelectedPositionChange(position, prevPosition);
}
mTabStrip.onViewPagerPageChanged(position, positionOffset); mTabStrip.onViewPagerPageChanged(position, positionOffset);
View selectedTitle = mTabStrip.getChildAt(position); View selectedTitle = mTabStrip.getChildAt(position);

16
tns-core-modules/ui/tabs/tabs.android.ts
View File

@ -248,18 +248,14 @@ function initializeNativeClasses() {
return; return;
} }
if (position !== prevPosition) { const tabStripItems = owner.tabStrip && owner.tabStrip.items;
const tabStripItems = owner.tabStrip && owner.tabStrip.items;
if (position >= 0 && tabStripItems && tabStripItems[position]) { if (position >= 0 && tabStripItems && tabStripItems[position]) {
tabStripItems[position]._emit(TabStripItem.selectEvent); tabStripItems[position]._emit(TabStripItem.selectEvent);
} }
if (prevPosition >= 0 && tabStripItems && tabStripItems[prevPosition]) { if (prevPosition >= 0 && tabStripItems && tabStripItems[prevPosition]) {
tabStripItems[prevPosition]._emit(TabStripItem.unselectEvent); tabStripItems[prevPosition]._emit(TabStripItem.unselectEvent);
}
owner.selectedIndex = position;
} }
} }