javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): improve loaded/unloaded handling to be stable and consistent (#10170)

Browse Source
This commit is contained in:
Nathan Walker
2023-01-15 19:49:28 -08:00
committed by GitHub
parent a69a9d6921
commit c9e29aa9af
12 changed files with 121 additions and 166 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
packages/core/data/observable/index.ts
View File

@@ -291,22 +291,24 @@ export class Observable implements ObservableDefinition {
}
for (let i = observers.length - 1; i >= 0; i--) {
const entry = observers[i];
if (entry.once) {
observers.splice(i, 1);
}
if (entry) {
if (entry.once) {
observers.splice(i, 1);
}
let returnValue;
if (entry.thisArg) {
returnValue = entry.callback.apply(entry.thisArg, [data]);
} else {
returnValue = entry.callback(data);
}
let returnValue;
if (entry.thisArg) {
returnValue = entry.callback.apply(entry.thisArg, [data]);
} else {
returnValue = entry.callback(data);
}
// This ensures errors thrown inside asynchronous functions do not get swallowed
if (returnValue && returnValue instanceof Promise) {
returnValue.catch((err) => {
console.error(err);
});
// This ensures errors thrown inside asynchronous functions do not get swallowed
if (returnValue && returnValue instanceof Promise) {
returnValue.catch((err) => {
console.error(err);
});
}
}
}
}