diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index bcbd472ae..b382cc4f6 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,12 +1,37 @@ -To help the rest of the community review your change, please ensure: + -### PR has a meaningful title -A good title is less than 50 characters and starts with a capital -letter, similar to a good [Git Commit Message] (http://chris.beams.io/posts/git-commit/). + + -### The commit message references a specific issue in this repo -Fixes/Implements #[Issue Number]. +## PR Checklist -### You have [unit tests](https://github.com/NativeScript/NativeScript/blob/master/running-tests.md) -if appropriate. +- [ ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. +- [ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. +- [ ] You have signed the [CLA](http://www.nativescript.org/cla). +- [ ] All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests. +- [ ] Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md. + +## What is the current behavior? + + +## What is the new behavior? + + +Fixes/Implements/Closes #[Issue Number]. + + + +