From b70f6edff27ce6f1a259c506a8b3c4d8e835c15c Mon Sep 17 00:00:00 2001 From: Vladimir Enchev Date: Thu, 17 Sep 2015 15:39:40 +0300 Subject: [PATCH 1/2] throw error if event names is not string --- data/observable/observable.ts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/data/observable/observable.ts b/data/observable/observable.ts index adbcadc19..9d2c0e48c 100644 --- a/data/observable/observable.ts +++ b/data/observable/observable.ts @@ -53,7 +53,12 @@ export class Observable implements definition.Observable { } public addEventListener(eventNames: string, callback: (data: definition.EventData) => void, thisArg?: any) { + if (!types.isString(eventNames)) { + throw new TypeError("Events name(s) must be string."); + } + types.verifyCallback(callback); + var events: Array = eventNames.split(","); for (var i = 0, l = events.length; i < l; i++) { @@ -68,6 +73,10 @@ export class Observable implements definition.Observable { } public removeEventListener(eventNames: string, callback?: any, thisArg?: any) { + if (!types.isString(eventNames)) { + throw new TypeError("Events name(s) must be string."); + } + var events: Array = eventNames.split(","); for (var i = 0, l = events.length; i < l; i++) { From 6a6beac9f93d58b4ec5d3f96856740c92f5feab1 Mon Sep 17 00:00:00 2001 From: Vladimir Enchev Date: Thu, 17 Sep 2015 15:39:55 +0300 Subject: [PATCH 2/2] TypeScriptToolsVersion updated to 1.6 --- CrossPlatformModules.csproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CrossPlatformModules.csproj b/CrossPlatformModules.csproj index 6f70de19b..474b27b98 100644 --- a/CrossPlatformModules.csproj +++ b/CrossPlatformModules.csproj @@ -3,7 +3,7 @@ 12.0 $(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion) - 1.5 + 1.6 {2313F1BF-1F2D-4F11-806A-87927FA6A7C0} {349c5851-65df-11da-9384-00065b846f21};{fae04ec0-301f-11d3-bf4b-00c04f79efbc} Library @@ -1977,7 +1977,7 @@ False - + \ No newline at end of file