From c27843024050115c3ee058828ed6f404d513c07a Mon Sep 17 00:00:00 2001 From: Jason Cassidy <47318351+jcassidyav@users.noreply.github.com> Date: Thu, 22 Jun 2023 20:19:56 +0100 Subject: [PATCH] fix(core): unhandled error typings (#10320) NativeScriptError type def used to come from packages/core/global-types.d.ts now comes from packages/core/application/application-interfaces.ts, so fixed there now. --- apps/automated/src/main.ts | 8 ++++---- packages/core/application/application-interfaces.ts | 10 +++++++++- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/apps/automated/src/main.ts b/apps/automated/src/main.ts index 05cbb7bf8..1d5076d37 100644 --- a/apps/automated/src/main.ts +++ b/apps/automated/src/main.ts @@ -80,14 +80,14 @@ Application.on(Application.lowMemoryEvent, function (args: ApplicationEventData) // Error events. Application.on(Application.uncaughtErrorEvent, function (args: UnhandledErrorEventData) { console.log('NativeScriptError:', args.error); - console.log((args.error).nativeException ?? (args.error).nativeError); - console.log((args.error).stackTrace ?? (args.error).stack); + console.log(args.error.nativeException ?? (args.error).nativeError); + console.log(args.error.stackTrace ?? args.error.stack); }); Application.on(Application.discardedErrorEvent, function (args: DiscardedErrorEventData) { console.log('[Discarded] NativeScriptError:', args.error); - console.log((args.error).nativeException ?? (args.error).nativeError); - console.log((args.error).stackTrace ?? (args.error).stack); + console.log(args.error.nativeException ?? (args.error).nativeError); + console.log(args.error.stackTrace ?? args.error.stack); }); // Android activity events. diff --git a/packages/core/application/application-interfaces.ts b/packages/core/application/application-interfaces.ts index 83f92f388..4580b36e2 100644 --- a/packages/core/application/application-interfaces.ts +++ b/packages/core/application/application-interfaces.ts @@ -9,7 +9,15 @@ export interface NativeScriptError extends Error { /** * Represents the native error object. */ - nativeError: any; + nativeException?: any; + /** + * The native stack trace. + */ + stackTrace?: string; + /** + * Javascript portion of stack trace. + */ + stack?: string; } /**