fix(core): box-shadow 'none' handling (#10405)

This commit is contained in:
Nathan Walker
2023-10-14 14:22:15 -07:00
committed by GitHub
parent 212d086676
commit c23695c477
6 changed files with 80 additions and 62 deletions

View File

@@ -1,4 +1,6 @@
import { Trace } from '../../trace';
import { CoreTypes } from '../../core-types';
import { Length } from './style-properties';
export function cleanupImportantFlags(value: string, propertyName: string) {
const index = value?.indexOf('!important');
@@ -10,3 +12,60 @@ export function cleanupImportantFlags(value: string, propertyName: string) {
}
return value;
}
/**
* Matches whitespace except if the whitespace is contained in parenthesis - ex. rgb(a), hsl color.
*/
const PARTS_RE = /\s(?![^(]*\))/;
/**
* Matches a Length value with or without a unit
*/
const LENGTH_RE = /^-?[0-9]+[a-zA-Z%]*?$/;
/**
* Checks if the value is a Length or 0
*/
const isLength = (v) => v === '0' || LENGTH_RE.test(v);
export function parseCSSShorthand(value: string): {
values: Array<CoreTypes.LengthType>;
color: string;
inset: boolean;
} {
const parts = value.trim().split(PARTS_RE);
const first = parts[0];
if (['', 'none'].includes(first)) {
return {
inset: false,
color: undefined,
values: [],
};
} else {
const inset = parts.includes('inset');
const last = parts[parts.length - 1];
let color = 'black';
if (first && !isLength(first) && first !== 'inset') {
color = first;
} else if (last && !isLength(last)) {
color = last;
}
const values = parts
.filter((n) => n !== 'inset')
.filter((n) => n !== color)
.map((val) => {
try {
return Length.parse(val);
} catch (err) {
return CoreTypes.zeroLength;
}
});
return {
inset,
color,
values,
};
}
}