From 8759aa000dc9ae38e14216e5652df76eaf810001 Mon Sep 17 00:00:00 2001 From: Dimitar Topuzov Date: Tue, 17 Mar 2020 10:10:12 +0200 Subject: [PATCH 1/4] chore: cut 6.5.0 release (#8443) * release: cut 6.5.0 release * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Vasil Trifonov --- CHANGELOG.md | 19 +++++++++++++++++++ nativescript-core/package.json | 16 +++++++++------- tns-core-modules-package/package.json | 2 +- tns-platform-declarations/package.json | 2 +- 4 files changed, 30 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4a7076f3b..c4f31053e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,22 @@ +# [6.5.0](https://github.com/NativeScript/NativeScript/compare/6.4.2...6.5.0) (2020-03-18) + + +### Bug Fixes + +* Fix issue for view not being removed from its parent ([#8432](https://github.com/NativeScript/NativeScript/issues/8432)) ([e081340](https://github.com/NativeScript/NativeScript/commit/e081340665605c54530587cc0cce9bc339585557)) +* **d.ts:** Update iOS typings iOS 13.2 ([#8430](https://github.com/NativeScript/NativeScript/issues/8430)) ([18a9b1a](https://github.com/NativeScript/NativeScript/commit/18a9b1aea89ee9defee990ace7d2409327a47a28)) +* **bottom-nav:** Android TabStripItems not aligned correctly when one of the image is smaller ([#8414](https://github.com/NativeScript/NativeScript/issues/8414))([9830be7](https://github.com/NativeScript/NativeScript/commit/9830be7230355638ace604145a3e3fad393c2a93)) +* **tabs:** delay loadView when animation runs ([#8353](https://github.com/NativeScript/NativeScript/issues/8353)) ([e649a6c](https://github.com/NativeScript/NativeScript/commit/e649a6cfd618c86a1dc7fa84e3197dfb78c3bc74)) + + +### Features + +* **tabs:** Tabs styling improvements ([#8366](https://github.com/NativeScript/NativeScript/pull/8366))([4589431](https://github.com/NativeScript/NativeScript/commit/458943111e909fcdad47d12e7ee4bcd9732f4e90)) +* **tabs:** Added selectedItemColor and unSelectedItemColor to the TabStrip ([#8435](https://github.com/NativeScript/NativeScript/issues/8435))([243dc98](https://github.com/NativeScript/NativeScript/commit/243dc98005d43617872da5cfc010e76178aa7f97)) +* **gestures:** add locationX and locationY to double tap event data ([#8338](https://github.com/NativeScript/NativeScript/pull/8338))([5ff78e2](https://github.com/NativeScript/NativeScript/commit/5ff78e2ad2612259bff36d3aaf5a0292309f5a78)) +* **tabs:** Added iconClass property to TabStripItem ([#8439](https://github.com/NativeScript/NativeScript/issues/8439))([270988d](https://github.com/NativeScript/NativeScript/commit/270988d26e1eeab97b4e5781451388e3a0a347e3)) + + ## [6.4.2](https://github.com/NativeScript/NativeScript/compare/6.4.1...6.4.2) (2020-02-27) diff --git a/nativescript-core/package.json b/nativescript-core/package.json index 0dbf2e07a..7fbc6857a 100644 --- a/nativescript-core/package.json +++ b/nativescript-core/package.json @@ -41,12 +41,14 @@ "ios": "6.0.0", "android": "6.0.0" }, - "hooks": [{ - "name": "nativescript-core", - "type": "before-checkForChanges", - "script": "cli-hooks/before-checkForChanges.js", - "inject": true - }] + "hooks": [ + { + "name": "nativescript-core", + "type": "before-checkForChanges", + "script": "cli-hooks/before-checkForChanges.js", + "inject": true + } + ] }, "snapshot": { "android": { @@ -58,4 +60,4 @@ } } } -} \ No newline at end of file +} diff --git a/tns-core-modules-package/package.json b/tns-core-modules-package/package.json index 6f6f124b1..25ea21d55 100644 --- a/tns-core-modules-package/package.json +++ b/tns-core-modules-package/package.json @@ -22,4 +22,4 @@ "android": "5.0.0" } } -} \ No newline at end of file +} diff --git a/tns-platform-declarations/package.json b/tns-platform-declarations/package.json index e4ef21b7d..363803f85 100644 --- a/tns-platform-declarations/package.json +++ b/tns-platform-declarations/package.json @@ -34,4 +34,4 @@ "devDependencies": { "typescript": "^3.7.5" } -} \ No newline at end of file +} From 0a7bee61d9a7744179e34dca5485758a941b350e Mon Sep 17 00:00:00 2001 From: Vasil Trifonov Date: Thu, 26 Mar 2020 19:15:27 +0200 Subject: [PATCH 2/4] fix(tabs): dynamic styling colors fixed (#8460) * fix(tabs): dynamic styling colors fixed * test(tabs): adding dynamic color change test --- .../dynamic-color-change-page.css | 25 +++++++++++ .../dynamic-color-change-page.ts | 10 +++++ .../dynamic-color-change-page.xml | 43 +++++++++++++++++++ .../app/bottom-navigation/main-page.ts | 1 + .../app/tabs/dynamic-color-change-page.css | 25 +++++++++++ .../app/tabs/dynamic-color-change-page.ts | 10 +++++ .../app/tabs/dynamic-color-change-page.xml | 43 +++++++++++++++++++ e2e/ui-tests-app/app/tabs/main-page.ts | 1 + .../bottom-navigation.e2e-spec.ts | 30 +++++++++++++ .../tabs/tabs-tests.e2e-spec.ts | 30 +++++++++++++ .../bottom-navigation.android.ts | 21 +++++++++ nativescript-core/ui/tabs/tabs.android.ts | 21 +++++++++ nativescript-core/ui/tabs/tabs.ios.ts | 2 + 13 files changed, 262 insertions(+) create mode 100644 e2e/ui-tests-app/app/bottom-navigation/dynamic-color-change-page.css create mode 100644 e2e/ui-tests-app/app/bottom-navigation/dynamic-color-change-page.ts create mode 100644 e2e/ui-tests-app/app/bottom-navigation/dynamic-color-change-page.xml create mode 100644 e2e/ui-tests-app/app/tabs/dynamic-color-change-page.css create mode 100644 e2e/ui-tests-app/app/tabs/dynamic-color-change-page.ts create mode 100644 e2e/ui-tests-app/app/tabs/dynamic-color-change-page.xml diff --git a/e2e/ui-tests-app/app/bottom-navigation/dynamic-color-change-page.css b/e2e/ui-tests-app/app/bottom-navigation/dynamic-color-change-page.css new file mode 100644 index 000000000..46d672d3e --- /dev/null +++ b/e2e/ui-tests-app/app/bottom-navigation/dynamic-color-change-page.css @@ -0,0 +1,25 @@ +.font-awesome { + font-family: "FontAwesome"; +} + +.font-size { + font-size: 36; +} + +TabStripItem:active { + background-color: magenta; +} + +.defaultCssClass { + background-color: #79d2a6; + highlight-color: green; + selected-item-color: yellow; + un-selected-item-color: blue; +} + +.newTabsClass { + background-color: orangered; + highlight-color: lightgreen; + selected-item-color: whitesmoke; + un-selected-item-color: pink; +} \ No newline at end of file diff --git a/e2e/ui-tests-app/app/bottom-navigation/dynamic-color-change-page.ts b/e2e/ui-tests-app/app/bottom-navigation/dynamic-color-change-page.ts new file mode 100644 index 000000000..a815c39a3 --- /dev/null +++ b/e2e/ui-tests-app/app/bottom-navigation/dynamic-color-change-page.ts @@ -0,0 +1,10 @@ +import { View } from "tns-core-modules/ui/core/view"; +import { Page } from "tns-core-modules/ui/page"; +import { BottomNavigation } from "tns-core-modules/ui/bottom-navigation"; + +export function onButtonTap(args) { + const page = (args.object).page; + const bottomNavigation = (page.getViewById("bottomNavigation")); + + bottomNavigation.tabStrip.className = "newTabsClass"; +} \ No newline at end of file diff --git a/e2e/ui-tests-app/app/bottom-navigation/dynamic-color-change-page.xml b/e2e/ui-tests-app/app/bottom-navigation/dynamic-color-change-page.xml new file mode 100644 index 000000000..f76227b01 --- /dev/null +++ b/e2e/ui-tests-app/app/bottom-navigation/dynamic-color-change-page.xml @@ -0,0 +1,43 @@ + + + +