javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-04 12:58:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): errors get swallowed if thrown inside async event functions (#10030)

Browse Source
This commit is contained in:
Dimitris-Rafail Katsampas
2022-09-28 02:57:11 +03:00
committed by GitHub
parent e3255c00d8
commit bdade0f0d5
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/core/data/observable/index.ts
View File

@ -294,10 +294,19 @@ export class Observable implements ObservableDefinition {
if (entry.once) { if (entry.once) {
observers.splice(i, 1); observers.splice(i, 1);
} }
let returnValue;
if (entry.thisArg) { if (entry.thisArg) {
entry.callback.apply(entry.thisArg, [data]); returnValue = entry.callback.apply(entry.thisArg, [data]);
} else { } else {
entry.callback(data); returnValue = entry.callback(data);
}
// This ensures errors thrown inside asynchronous functions do not get swallowed
if (returnValue && returnValue instanceof Promise) {
returnValue.catch((err) => {
console.error(err);
});
} }
} }
} }