javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-16 20:11:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

keep some variable from early GC to speed up start time (#5823)

Browse Source 
* keep some variable from early GC to speed up start time

* do not clear callbacks, as they shouldn't use much memory
This commit is contained in:
Vasil Trifonov
2018-05-17 11:55:15 +03:00
committed by GitHub
parent ca444aa8ed
commit bbe25d7ec1
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tns-core-modules/application/application.android.ts
View File

@ -45,6 +45,8 @@ export class AndroidApplication extends Observable implements AndroidApplication
public foregroundActivity: android.app.Activity; public foregroundActivity: android.app.Activity;
public startActivity: android.app.Activity; public startActivity: android.app.Activity;
public packageName: string; public packageName: string;
// we are using these property to store the callbacks to avoid early GC collection which would trigger MarkReachableObjects
private callbacks: any = {};
public get currentContext(): android.content.Context { public get currentContext(): android.content.Context {
return this.foregroundActivity; return this.foregroundActivity;
@ -63,10 +65,11 @@ export class AndroidApplication extends Observable implements AndroidApplication
this.packageName = nativeApp.getPackageName(); this.packageName = nativeApp.getPackageName();
this.context = nativeApp.getApplicationContext(); this.context = nativeApp.getApplicationContext();
let lifecycleCallbacks = initLifecycleCallbacks(); // we store those callbacks and add a function for clearing them later so that the objects will be eligable for GC
let componentCallbacks = initComponentCallbacks(); this.callbacks.lifecycleCallbacks = initLifecycleCallbacks();
this.nativeApp.registerActivityLifecycleCallbacks(lifecycleCallbacks); this.callbacks.componentCallbacks = initComponentCallbacks();
this.nativeApp.registerComponentCallbacks(componentCallbacks); this.nativeApp.registerActivityLifecycleCallbacks(this.callbacks.lifecycleCallbacks);
this.nativeApp.registerComponentCallbacks(this.callbacks.componentCallbacks);
this._registerPendingReceivers(); this._registerPendingReceivers();
} }
@ -190,7 +193,7 @@ export function getNativeApplication(): android.app.Application {
// the getInstance might return null if com.tns.NativeScriptApplication exists but is not the starting app type // the getInstance might return null if com.tns.NativeScriptApplication exists but is not the starting app type
if (!nativeApp) { if (!nativeApp) {
// TODO: Should we handle the case when a custom application type is provided and the user has not explicitly initialized the application module? // TODO: Should we handle the case when a custom application type is provided and the user has not explicitly initialized the application module?
const clazz = java.lang.Class.forName("android.app.ActivityThread"); const clazz = java.lang.Class.forName("android.app.ActivityThread");
if (clazz) { if (clazz) {
const method = clazz.getMethod("currentApplication", null); const method = clazz.getMethod("currentApplication", null);
@ -235,14 +238,15 @@ function initLifecycleCallbacks() {
const subscribeForGlobalLayout = profile("subscribeForGlobalLayout", function (activity: android.app.Activity) { const subscribeForGlobalLayout = profile("subscribeForGlobalLayout", function (activity: android.app.Activity) {
const rootView = activity.getWindow().getDecorView().getRootView(); const rootView = activity.getWindow().getDecorView().getRootView();
let onGlobalLayoutListener = new android.view.ViewTreeObserver.OnGlobalLayoutListener({ // store the listener not to trigger GC collection before collecting the method
this.onGlobalLayoutListener = new android.view.ViewTreeObserver.OnGlobalLayoutListener({
onGlobalLayout() { onGlobalLayout() {
notify({ eventName: displayedEvent, object: androidApp, activity }); notify({ eventName: displayedEvent, object: androidApp, activity });
let viewTreeObserver = rootView.getViewTreeObserver(); let viewTreeObserver = rootView.getViewTreeObserver();
viewTreeObserver.removeOnGlobalLayoutListener(onGlobalLayoutListener); viewTreeObserver.removeOnGlobalLayoutListener(this.onGlobalLayoutListener);
} }
}); });
rootView.getViewTreeObserver().addOnGlobalLayoutListener(onGlobalLayoutListener); rootView.getViewTreeObserver().addOnGlobalLayoutListener(this.onGlobalLayoutListener);
}); });
const lifecycleCallbacks = new android.app.Application.ActivityLifecycleCallbacks({ const lifecycleCallbacks = new android.app.Application.ActivityLifecycleCallbacks({