javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: android Tabs selected item color incorrectly applied (#9040)

Browse Source 
* fix: selected-item-color gets applied to wrong TabStripItems

* chore: Added selection colors to 2 ui examples.

* chore: Removing used for testing.
This commit is contained in:
Dimitris - Rafail Katsampas
2020-12-28 14:50:23 +02:00
committed by GitHub
parent e16bc606ef
commit b47ce0a97c
8 changed files with 42 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/ui-mobile-base/android/widgets/src/main/java/org/nativescript/widgets/TabViewPager.java
View File

@@ -56,7 +56,7 @@ public class TabViewPager extends ViewPager {
@Override
public void setCurrentItem(int item) {
boolean smoothScroll = this.animationEnabled && this.swipePageEnabled;
boolean smoothScroll = this.animationEnabled;
super.setCurrentItem(item, smoothScroll);
}
}

10
packages/ui-mobile-base/android/widgets/src/main/java/org/nativescript/widgets/TabsBar.java
View File

@@ -317,10 +317,6 @@ public class TabsBar extends HorizontalScrollView {
return true;
}
public void onSelectedPositionChange(int position, int prevPosition) {
// to be overridden in JS
}
private void populateTabStrip() {
final PagerAdapter adapter = mViewPager.getAdapter();
final OnClickListener tabClickListener = new TabClickListener();
@@ -394,12 +390,6 @@ public class TabsBar extends HorizontalScrollView {
return;
}
int prevPosition = mTabStrip.getSelectedPosition();
if (prevPosition != position) {
onSelectedPositionChange(position, prevPosition);
}
mTabStrip.onTabsViewPagerPageChanged(position, positionOffset);
View selectedTitle = mTabStrip.getChildAt(position);