diff --git a/build/tslint.json b/build/tslint.json index f8f80120b..c457ffe31 100644 --- a/build/tslint.json +++ b/build/tslint.json @@ -3,7 +3,7 @@ "arrow-return-shorthand": true, "class-name": true, "curly": true, - "deprecation": false, + "deprecation": true, "forin": false, "indent": [true, "spaces", 4], "jsdoc-format": false, diff --git a/e2e/modal-navigation/app/home/home-page.ts b/e2e/modal-navigation/app/home/home-page.ts index 1ce7f9179..2746f8df1 100644 --- a/e2e/modal-navigation/app/home/home-page.ts +++ b/e2e/modal-navigation/app/home/home-page.ts @@ -1,5 +1,4 @@ import * as application from "tns-core-modules/application"; -import { StackLayout } from "tns-core-modules/ui/layouts/stack-layout"; import { NavigatedData, Page } from "tns-core-modules/ui/page"; import { View, EventData, ShowModalOptions } from "tns-core-modules/ui/core/view"; import { Frame } from "tns-core-modules/ui/frame"; @@ -23,10 +22,17 @@ export function onNavigatedFrom(args: NavigatedData) { export function onModalNoPage(args: EventData) { const view = args.object as View; - view.showModal("modal-no-page/modal-no-page", - "context", - () => console.log("home-page modal frame closed"), - false); + view.showModal("modal-no-page/modal-no-page", { + context: "context", + closeCallback: () => console.log("home-page modal frame closed"), + fullscreen: false + }); + + view.showModal("modal-no-page/modal-no-page", { + context: "context", + closeCallback: () => console.log("home-page modal frame closed"), + fullscreen: false + }); } export function onPopoverModal(args: EventData) { @@ -49,49 +55,51 @@ export function onModalFrame(args: EventData) { const frame = new Frame(); frame.navigate("modal/modal-page"); - view.showModal(frame, - "context", - () => console.log("home-page modal frame closed"), - false); + view.showModal(frame, { + context: "context", + closeCallback: () => console.log("home-page modal frame closed"), + fullscreen: false + }); } export function onModalPage(args: EventData) { const view = args.object as View; - view.showModal("modal/modal-page", - { frameless: true }, - () => console.log("home-page modal page closed"), - false); + view.showModal("modal/modal-page", { + context: { frameless: true }, + closeCallback: () => console.log("home-page modal page closed"), + fullscreen: false + }); } export function onModalLayout(args: EventData) { const view = args.object as View; - view.showModal("modal-layout/modal-layout-root", - "context", - () => console.log("home-page modal layout closed"), - false); + view.showModal("modal-layout/modal-layout-root", { + context: "context", + closeCallback: () => console.log("home-page modal layout closed"), + fullscreen: false + }); } export function onAndroidBackEvents(args: EventData) { const view = args.object as View; - view.showModal( - "android-back-button/android-back-button-page", - null, - () => console.log("android-back-button modal page layout closed"), - true, true, true); + view.showModal("android-back-button/android-back-button-page", { + context: null, + closeCallback: () => console.log("android-back-button modal page layout closed"), + fullscreen: true, + animated: true, + stretched: true + }); } export function onModalTabView(args: EventData) { - const fullscreen = false; - const animated = false; - const stretched = true; - const view = args.object as View; - view.showModal("modal-tab/modal-tab-root", - { frameless: true }, - () => console.log("home-page modal tabview closed"), - fullscreen, - animated, - stretched); + view.showModal("modal-tab/modal-tab-root", { + context: { frameless: true }, + closeCallback: () => console.log("home-page modal tabview closed"), + fullscreen: false, + animated: false, + stretched: true + }); } export function onNavigate(args: EventData) { diff --git a/e2e/modal-navigation/app/modal-nested/modal-nested-page.ts b/e2e/modal-navigation/app/modal-nested/modal-nested-page.ts index 125b9a3ee..ac9afe51e 100644 --- a/e2e/modal-navigation/app/modal-nested/modal-nested-page.ts +++ b/e2e/modal-navigation/app/modal-nested/modal-nested-page.ts @@ -1,4 +1,3 @@ -import { StackLayout } from "tns-core-modules/ui/layouts/stack-layout"; import { NavigatedData } from "tns-core-modules/ui/page"; import { View, EventData } from "tns-core-modules/ui/core/view"; diff --git a/e2e/modal-navigation/app/modal-no-page/modal-no-page.ts b/e2e/modal-navigation/app/modal-no-page/modal-no-page.ts index 2652b50bd..773e67664 100644 --- a/e2e/modal-navigation/app/modal-no-page/modal-no-page.ts +++ b/e2e/modal-navigation/app/modal-no-page/modal-no-page.ts @@ -1,8 +1,4 @@ -import { StackLayout } from "tns-core-modules/ui/layouts/stack-layout"; -import { NavigatedData, Page } from "tns-core-modules/ui/page"; import { View, EventData } from "tns-core-modules/ui/core/view"; -import { Frame, ShownModallyData } from "tns-core-modules/ui/frame"; -import { fromObject } from "tns-core-modules/data/observable"; import { confirm } from "tns-core-modules/ui/dialogs"; export function onLoaded(args) { diff --git a/e2e/modal-navigation/app/modal-second/modal-second-page.ts b/e2e/modal-navigation/app/modal-second/modal-second-page.ts index cc489fba8..f1f1db001 100644 --- a/e2e/modal-navigation/app/modal-second/modal-second-page.ts +++ b/e2e/modal-navigation/app/modal-second/modal-second-page.ts @@ -1,7 +1,5 @@ -import { StackLayout } from "tns-core-modules/ui/layouts/stack-layout"; import { NavigatedData, Page } from "tns-core-modules/ui/page"; import { View, EventData } from "tns-core-modules/ui/core/view"; -import { Frame } from "tns-core-modules/ui/frame"; export function onNavigatingTo(args: NavigatedData) { console.log("second-page onNavigatingTo"); diff --git a/e2e/modal-navigation/app/modal/modal-page.ts b/e2e/modal-navigation/app/modal/modal-page.ts index 6de08686d..2ba9f99aa 100644 --- a/e2e/modal-navigation/app/modal/modal-page.ts +++ b/e2e/modal-navigation/app/modal/modal-page.ts @@ -1,4 +1,3 @@ -import { StackLayout } from "tns-core-modules/ui/layouts/stack-layout"; import { NavigatedData, Page } from "tns-core-modules/ui/page"; import { View, EventData } from "tns-core-modules/ui/core/view"; import { Frame, ShownModallyData } from "tns-core-modules/ui/frame"; @@ -46,19 +45,21 @@ export function showNestedModalFrame(args: EventData) { const frame = new Frame(); frame.navigate("modal-nested/modal-nested-page"); - view.showModal(frame, - "nested-context", - () => console.log("modal frame nested closed"), - false); + view.showModal(frame, { + context: "nested-context", + closeCallback: () => console.log("modal frame nested closed"), + fullscreen: false + }); } export function showNestedModalPage(args: EventData) { const view = args.object as View; - view.showModal("modal-nested/modal-nested-page", - "nested-context", - () => console.log("modal page nested closed"), - false); + view.showModal("modal-nested/modal-nested-page", { + context: "nested-context", + closeCallback: () => console.log("modal page nested closed"), + fullscreen: false + }); } export function onNavigate(args: EventData) { diff --git a/e2e/modal-navigation/app/second/second-page.ts b/e2e/modal-navigation/app/second/second-page.ts index 9b4514fb4..afcaaf791 100644 --- a/e2e/modal-navigation/app/second/second-page.ts +++ b/e2e/modal-navigation/app/second/second-page.ts @@ -1,4 +1,3 @@ -import { StackLayout } from "tns-core-modules/ui/layouts/stack-layout"; import { NavigatedData, Page } from "tns-core-modules/ui/page"; import { View, EventData } from "tns-core-modules/ui/core/view"; import { Frame } from "tns-core-modules/ui/frame"; @@ -31,16 +30,18 @@ export function onModalFrame(args: EventData) { const frame = new Frame(); frame.navigate("modal/modal-page"); - view.showModal(frame, - "context", - () => console.log("home-page modal frame closed"), - false); + view.showModal(frame, { + context: "context", + closeCallback: () => console.log("home-page modal frame closed"), + fullscreen: false + }); } export function onModalPage(args: EventData) { const view = args.object as View; - view.showModal("modal/modal-page", - { frameless: true }, - () => console.log("home-page modal page closed"), - false); + view.showModal("modal/modal-page", { + context: { frameless: true }, + closeCallback: () => console.log("home-page modal page closed"), + fullscreen: false + }); } diff --git a/e2e/modal-navigation/e2e/modal-page.e2e-spec.ts b/e2e/modal-navigation/e2e/modal-page.e2e-spec.ts index bf978fba9..94dd21502 100644 --- a/e2e/modal-navigation/e2e/modal-page.e2e-spec.ts +++ b/e2e/modal-navigation/e2e/modal-page.e2e-spec.ts @@ -3,7 +3,6 @@ import { Screen, driverDefaultWaitTime } from "./screen" import { roots, modalPageBackground, - testSecondPageBackground, testNestedModalFrameBackground, testNestedModalPageBackground, testDialogBackground diff --git a/e2e/modal-navigation/e2e/modal-tab.e2e-spec.ts b/e2e/modal-navigation/e2e/modal-tab.e2e-spec.ts index ddfde1168..adebdb90d 100644 --- a/e2e/modal-navigation/e2e/modal-tab.e2e-spec.ts +++ b/e2e/modal-navigation/e2e/modal-tab.e2e-spec.ts @@ -2,7 +2,6 @@ import { AppiumDriver, createDriver, nsCapabilities } from "nativescript-dev-app import { Screen, driverDefaultWaitTime } from "./screen" import { roots, - modalFrameBackground, modalTabViewBackground, testSecondPageBackground, testSecondPageClose, diff --git a/e2e/modal-navigation/e2e/shared.e2e-spec.ts b/e2e/modal-navigation/e2e/shared.e2e-spec.ts index c1f6dd3a6..72cf61a31 100644 --- a/e2e/modal-navigation/e2e/shared.e2e-spec.ts +++ b/e2e/modal-navigation/e2e/shared.e2e-spec.ts @@ -1,4 +1,4 @@ -import { AppiumDriver, createDriver } from "nativescript-dev-appium"; +import { AppiumDriver } from "nativescript-dev-appium"; import { Screen } from "./screen" const time = 1; diff --git a/e2e/ui-tests-app/app/action-bar/modal-test-hidden-action-bar-page.ts b/e2e/ui-tests-app/app/action-bar/modal-test-hidden-action-bar-page.ts index ea6c372a1..62eac666c 100644 --- a/e2e/ui-tests-app/app/action-bar/modal-test-hidden-action-bar-page.ts +++ b/e2e/ui-tests-app/app/action-bar/modal-test-hidden-action-bar-page.ts @@ -3,9 +3,11 @@ import { Page } from "tns-core-modules/ui/page"; import { topmost } from "tns-core-modules/ui/frame"; export function btnClick(args: EventData) { - (args.object).page.showModal("action-bar/modal-page", "", function (arg: string) { - console.log("Callback args: " + arg); - }, true); + (args.object).page.showModal("action-bar/modal-page", { + context: "", + closeCallback: (arg: string) => console.log("Callback args: " + arg), + fullscreen: true + }); } export function btnBack(args: EventData) { diff --git a/e2e/ui-tests-app/app/action-bar/modal-test-with-action-bar-page.ts b/e2e/ui-tests-app/app/action-bar/modal-test-with-action-bar-page.ts index 440fc34f9..f9fef469b 100644 --- a/e2e/ui-tests-app/app/action-bar/modal-test-with-action-bar-page.ts +++ b/e2e/ui-tests-app/app/action-bar/modal-test-with-action-bar-page.ts @@ -3,10 +3,11 @@ import { Page } from "tns-core-modules/ui/page"; import { topmost } from "tns-core-modules/ui/frame"; export function btnClick(args: EventData) { - (args.object).page.showModal("action-bar/modal-page-hidden-action-bar-page", "", function (arg: string) { - // ... - console.log("Callback args: " + arg); - }, true); + (args.object).page.showModal("action-bar/modal-page-hidden-action-bar-page", { + context: "", + closeCallback: (arg: string) => console.log("Callback args: " + arg), + fullscreen: true + }); } export function btnBack(args: EventData) { diff --git a/e2e/ui-tests-app/app/app.ts b/e2e/ui-tests-app/app/app.ts index ba8633c8a..e5658de53 100644 --- a/e2e/ui-tests-app/app/app.ts +++ b/e2e/ui-tests-app/app/app.ts @@ -90,6 +90,5 @@ application.on(application.discardedErrorEvent, function(args: application.Disca application.setCssFileName("app.css"); -application.start({ moduleName: "main-page" }); +application._start({ moduleName: "main-page" }); // application.run({ moduleName: "app-root" }); -// application.run(); diff --git a/e2e/ui-tests-app/app/css/background-image-linear-gradient-page.ts b/e2e/ui-tests-app/app/css/background-image-linear-gradient-page.ts index dce615cf2..c00a222e7 100644 --- a/e2e/ui-tests-app/app/css/background-image-linear-gradient-page.ts +++ b/e2e/ui-tests-app/app/css/background-image-linear-gradient-page.ts @@ -1,5 +1,4 @@ import * as pages from "tns-core-modules/ui/page"; -import { EventData } from "tns-core-modules/data/observable"; import * as button from "tns-core-modules/ui/button"; import { GridLayout } from "tns-core-modules/ui/layouts/grid-layout"; diff --git a/e2e/ui-tests-app/app/css/background-shorthand-page.ts b/e2e/ui-tests-app/app/css/background-shorthand-page.ts index 27b57f71d..7b0deba87 100644 --- a/e2e/ui-tests-app/app/css/background-shorthand-page.ts +++ b/e2e/ui-tests-app/app/css/background-shorthand-page.ts @@ -1,5 +1,4 @@ import * as pages from "tns-core-modules/ui/page"; -import { EventData } from "tns-core-modules/data/observable"; import * as button from "tns-core-modules/ui/button"; import { GridLayout } from "tns-core-modules/ui/layouts/grid-layout"; diff --git a/e2e/ui-tests-app/app/events/console-page.ts b/e2e/ui-tests-app/app/events/console-page.ts index ad9e75093..4e1fda0a0 100644 --- a/e2e/ui-tests-app/app/events/console-page.ts +++ b/e2e/ui-tests-app/app/events/console-page.ts @@ -1,5 +1,4 @@ -import * as app from "tns-core-modules/application"; -import * as pageModule from "tns-core-modules/ui/page"; +import * as pageModule from "tns-core-modules/ui/page"; import * as labelModule from "tns-core-modules/ui/label"; import * as stackLayoutModule from "tns-core-modules/ui/layouts/stack-layout"; import * as textViewModule from "tns-core-modules/ui/text-view"; diff --git a/e2e/ui-tests-app/app/events/layout-changed-event-page.ts b/e2e/ui-tests-app/app/events/layout-changed-event-page.ts index 9070896e8..316533c61 100644 --- a/e2e/ui-tests-app/app/events/layout-changed-event-page.ts +++ b/e2e/ui-tests-app/app/events/layout-changed-event-page.ts @@ -1,8 +1,6 @@ import { StackLayout } from "tns-core-modules/ui/layouts/stack-layout"; import { Button } from "tns-core-modules/ui/button"; import { TextView } from "tns-core-modules/ui/text-view"; -import { View } from "tns-core-modules/ui/core/view"; -import { EventData } from "tns-core-modules/data/observable"; let buttonsCount = 1; export function onLayoutChanged(args) { diff --git a/e2e/ui-tests-app/app/image-view/image-asset/view-model-page.ts b/e2e/ui-tests-app/app/image-view/image-asset/view-model-page.ts index af96a2c98..690744120 100644 --- a/e2e/ui-tests-app/app/image-view/image-asset/view-model-page.ts +++ b/e2e/ui-tests-app/app/image-view/image-asset/view-model-page.ts @@ -1,5 +1,4 @@ -import * as dialogs from "tns-core-modules/ui/dialogs"; -import * as observable from "tns-core-modules/data/observable"; +import * as observable from "tns-core-modules/data/observable"; import * as imageAssetModule from "tns-core-modules/image-asset"; import { ImageSource } from "tns-core-modules/image-source"; diff --git a/e2e/ui-tests-app/app/image-view/stretch-modes-page.ts b/e2e/ui-tests-app/app/image-view/stretch-modes-page.ts index c75ab9a56..07c72ef34 100644 --- a/e2e/ui-tests-app/app/image-view/stretch-modes-page.ts +++ b/e2e/ui-tests-app/app/image-view/stretch-modes-page.ts @@ -1,9 +1,6 @@ import { Image, Stretch } from "tns-core-modules/ui/image"; import { Label } from "tns-core-modules/ui/label"; import { LayoutBase } from "tns-core-modules/ui/layouts/layout-base"; -import { Color } from "tns-core-modules/color"; -import * as imageSource from "tns-core-modules/image-source"; -import { isAndroid } from "tns-core-modules/platform"; const sources = [ { w: 32, h: 18, src: "i32x18" }, diff --git a/e2e/ui-tests-app/app/issues/issue-3714-page.ts b/e2e/ui-tests-app/app/issues/issue-3714-page.ts index c7478a190..31ffef6fa 100644 --- a/e2e/ui-tests-app/app/issues/issue-3714-page.ts +++ b/e2e/ui-tests-app/app/issues/issue-3714-page.ts @@ -1,9 +1,7 @@ import { EventData } from "tns-core-modules/data/observable"; import { Page } from "tns-core-modules/ui/page"; import { Button } from "tns-core-modules/ui/button"; -import { Label } from "tns-core-modules/ui/label"; import { StackLayout } from "tns-core-modules/ui/layouts/stack-layout"; -import { GridLayout } from "tns-core-modules/ui/layouts/grid-layout"; export function toggle(args: EventData) { const page = ((args.object).page); diff --git a/e2e/ui-tests-app/app/tab-view/tab-view-css-page.ts b/e2e/ui-tests-app/app/tab-view/tab-view-css-page.ts index 1f0421c93..d5239ff93 100644 --- a/e2e/ui-tests-app/app/tab-view/tab-view-css-page.ts +++ b/e2e/ui-tests-app/app/tab-view/tab-view-css-page.ts @@ -1,7 +1,7 @@ import * as view from "tns-core-modules/ui/core/view"; import * as pages from "tns-core-modules/ui/page"; -export function loaded(args){ +export function loaded(args) { var page = (args.object).page; const view = page.getViewById("test-element"); (view).textTransform = "capitalize"; diff --git a/e2e/ui-tests-app/app/tab-view/tab-view-icon-change-page.ts b/e2e/ui-tests-app/app/tab-view/tab-view-icon-change-page.ts index 6ebd0d4fb..b72993f93 100644 --- a/e2e/ui-tests-app/app/tab-view/tab-view-icon-change-page.ts +++ b/e2e/ui-tests-app/app/tab-view/tab-view-icon-change-page.ts @@ -1,5 +1,3 @@ -import { EventData } from "tns-core-modules/data/observable"; -import { Button } from "tns-core-modules/ui/button"; import { TabView, SelectedIndexChangedEventData } from "tns-core-modules/ui/tab-view"; export function onSelectedIndexChanged(args: SelectedIndexChangedEventData) { diff --git a/e2e/ui-tests-app/app/tabs/default.ts b/e2e/ui-tests-app/app/tabs/default.ts index 85a232b6b..6ef17fcfa 100644 --- a/e2e/ui-tests-app/app/tabs/default.ts +++ b/e2e/ui-tests-app/app/tabs/default.ts @@ -1,6 +1,4 @@ import { EventData } from "tns-core-modules/data/observable"; -import { SubMainPageViewModel } from "../sub-main-page-view-model"; -import { WrapLayout } from "tns-core-modules/ui/layouts/wrap-layout"; import { Page } from "tns-core-modules/ui/page"; import { BottomNavigation } from "tns-core-modules/ui/bottom-navigation"; diff --git a/e2e/ui-tests-app/e2e/helpers/image-helper.ts b/e2e/ui-tests-app/e2e/helpers/image-helper.ts index 09a884b6e..9adcef27a 100644 --- a/e2e/ui-tests-app/e2e/helpers/image-helper.ts +++ b/e2e/ui-tests-app/e2e/helpers/image-helper.ts @@ -1,4 +1,4 @@ -import { AppiumDriver, logError, IRectangle, UIElement, logInfo, SearchOptions } from "nativescript-dev-appium"; +import { AppiumDriver, logError, IRectangle, UIElement } from "nativescript-dev-appium"; import { ImageOptions } from "nativescript-dev-appium/lib/image-options"; import { assert } from "chai"; diff --git a/e2e/ui-tests-app/e2e/helpers/navigation-helper.ts b/e2e/ui-tests-app/e2e/helpers/navigation-helper.ts index b84ed7cf5..dd04a8685 100644 --- a/e2e/ui-tests-app/e2e/helpers/navigation-helper.ts +++ b/e2e/ui-tests-app/e2e/helpers/navigation-helper.ts @@ -1,4 +1,4 @@ -import { AppiumDriver, logError, IRectangle, logInfo, SearchOptions } from "nativescript-dev-appium"; +import { AppiumDriver, IRectangle, logInfo } from "nativescript-dev-appium"; export class NavigationHelper { @@ -56,5 +56,3 @@ export class NavigationHelper { throw new Error("Not implemented!"); } } - - diff --git a/e2e/ui-tests-app/e2e/setup.ts b/e2e/ui-tests-app/e2e/setup.ts index 11b854fca..d53599331 100644 --- a/e2e/ui-tests-app/e2e/setup.ts +++ b/e2e/ui-tests-app/e2e/setup.ts @@ -1,5 +1,5 @@ import { startServer, stopServer, ITestReporter, nsCapabilities, LogImageType } from "nativescript-dev-appium"; -const addContext = require('mochawesome/addContext'); +const addContext = require("mochawesome/addContext"); const testReporterContext = {}; testReporterContext.name = "mochawesome"; diff --git a/e2e/ui-tests-app/e2e/suites/button/background/button-background.e2e-spec.ts b/e2e/ui-tests-app/e2e/suites/button/background/button-background.e2e-spec.ts index 7203445ae..6fa315614 100644 --- a/e2e/ui-tests-app/e2e/suites/button/background/button-background.e2e-spec.ts +++ b/e2e/ui-tests-app/e2e/suites/button/background/button-background.e2e-spec.ts @@ -1,5 +1,4 @@ -import { AppiumDriver, createDriver, SearchOptions, nsCapabilities } from "nativescript-dev-appium"; -import { assert } from "chai"; +import { AppiumDriver, createDriver, nsCapabilities } from "nativescript-dev-appium"; import { ButtonBackgroundPage } from "./button-background-page"; describe("button-background-suite", () => { @@ -76,12 +75,10 @@ describe("button-background-suite", () => { await backgroundPage.executeScenario("background_42_position", "42"); }); - it("background_43_position", async function () { await backgroundPage.executeScenario("background_43_position", "43"); }); - it("background_44_position", async function () { await backgroundPage.executeScenario("background_44_position", "44"); }); diff --git a/e2e/ui-tests-app/e2e/suites/tab-view/tab-view-base-page.ts b/e2e/ui-tests-app/e2e/suites/tab-view/tab-view-base-page.ts index cc3340ffd..df9aea540 100644 --- a/e2e/ui-tests-app/e2e/suites/tab-view/tab-view-base-page.ts +++ b/e2e/ui-tests-app/e2e/suites/tab-view/tab-view-base-page.ts @@ -1,6 +1,4 @@ -import { AppiumDriver, logInfo, logError } from "nativescript-dev-appium"; -import { Platform } from "mobile-devices-controller"; -import { ImageOptions } from "nativescript-dev-appium/lib/image-options"; +import { AppiumDriver } from "nativescript-dev-appium"; import { PageObjectBaseModel } from "../../page-object-base-model"; export class TabViewBasePage extends PageObjectBaseModel { diff --git a/e2e/ui-tests-app/e2e/suites/tab-view/tab-view-common-tests.e2e-suite.ts b/e2e/ui-tests-app/e2e/suites/tab-view/tab-view-common-tests.e2e-suite.ts index 0f5aab2f5..9a766c0ae 100644 --- a/e2e/ui-tests-app/e2e/suites/tab-view/tab-view-common-tests.e2e-suite.ts +++ b/e2e/ui-tests-app/e2e/suites/tab-view/tab-view-common-tests.e2e-suite.ts @@ -1,4 +1,4 @@ -import { nsCapabilities, createDriver, AppiumDriver, Direction } from "nativescript-dev-appium"; +import { nsCapabilities, createDriver, AppiumDriver } from "nativescript-dev-appium"; import { TabViewBasePage } from "./tab-view-base-page"; import { Platform } from "mobile-devices-controller"; @@ -77,10 +77,9 @@ describe("tab-view-common-tests-suite", async function () { await tabViewBasePage.navigateBackToSuitMainPage(); }); - it("tabView_icon_change", async function () { await tabViewBasePage.navigateToSample("tab-view-icon-change"); - const index = driver.nsCapabilities.device.platform == Platform.IOS + const index = driver.nsCapabilities.device.platform === Platform.IOS ? (driver.nsCapabilities.device.apiLevel >= 11 ? 2 : 3) : 1; let btns = await driver.findElementsByClassName(driver.locators.button, 5000); @@ -88,7 +87,7 @@ describe("tab-view-common-tests-suite", async function () { await tabViewBasePage.imageHelper.compareScreen("tabView_icon_change", 5, 0.01); btns = await driver.findElementsByClassName(driver.locators.button, 5000); - await btns[index -1 ].tap(); + await btns[index - 1].tap(); await tabViewBasePage.imageHelper.compareScreen("tabView_icon_change", 5, 0.01); await tabViewBasePage.imageHelper.assertImages(); diff --git a/package.json b/package.json index 31812ce45..cfb7e2cb8 100644 --- a/package.json +++ b/package.json @@ -82,7 +82,7 @@ "typedoc": "typedoc --tsconfig tsconfig.typedoc.json --out bin/dist/apiref --includeDeclarations --name NativeScript --theme ./node_modules/nativescript-typedoc-theme --excludeExternals --externalPattern \"**/+(tns-core-modules|module).d.ts\"", "dev-typedoc": "npm run typedoc && cd bin/dist/apiref && npx http-server", "test-tsc-es2016": "npm run tsc -- -p tsconfig.public.es2016.json", - "tslint": "tslint --project tsconfig.json --config build/tslint.json 'tns-core-modules/**/*.ts' 'tests/**/*.ts' 'apps/**/*.ts' 'e2e/**/*.ts' -e '**/node_modules/**' -e '**/platforms/**'", + "tslint": "tslint --project tsconfig.tslint.json --config build/tslint.json", "madge-ios": "tsc --skipLibCheck && tns prepare ios --path tests && madge --circular tests/platforms/ios/tests/app/tns_modules/tns-core-modules", "madge-ios-image": "tsc --skipLibCheck && tns prepare ios --path tests && madge --image graph-tests-ios.svg tests/platforms/ios/tests/app/tns_modules/tns-core-modules", "madge-android": "tsc --skipLibCheck && tns prepare android --path tests && madge --circular tests/platforms/android/app/src/main/assets/app/tns_modules/tns-core-modules", diff --git a/tests/app/application/application-tests.android.ts b/tests/app/application/application-tests.android.ts index c43af40dc..1b7db5ed4 100644 --- a/tests/app/application/application-tests.android.ts +++ b/tests/app/application/application-tests.android.ts @@ -1,6 +1,6 @@ /* tslint:disable:no-unused-variable */ import * as app from "tns-core-modules/application"; -import * as TKUnit from "../tk-unit"; +import * as TKUnit from "../tk-unit"; export * from "./application-tests-common"; @@ -40,7 +40,6 @@ if (app.android) { export var testAndroidApplicationInitialized = function () { TKUnit.assert(app.android, "Android application not initialized."); TKUnit.assert(app.android.context, "Android context not initialized."); - TKUnit.assert(app.android.currentContext, "Android currentContext not initialized."); TKUnit.assert(app.android.foregroundActivity, "Android foregroundActivity not initialized."); TKUnit.assert(app.android.foregroundActivity.isNativeScriptActivity, "Andorid foregroundActivity.isNativeScriptActivity is true"); TKUnit.assert(app.android.startActivity, "Android startActivity not initialized."); diff --git a/tests/app/data/observable-tests.ts b/tests/app/data/observable-tests.ts index 6fb6dfbfd..5c9823cde 100644 --- a/tests/app/data/observable-tests.ts +++ b/tests/app/data/observable-tests.ts @@ -575,5 +575,6 @@ export function test_fromObjectRecursive_does_not_override_source_object_propert const myObj = {}; const source = { name: "a", value: myObj }; const observable = fromObjectRecursive(source); + TKUnit.assertNotNull(observable); TKUnit.assertEqual(source.value, myObj); -} \ No newline at end of file +} diff --git a/tests/app/http/http-tests.ts b/tests/app/http/http-tests.ts index f924edffc..1eba2e1d9 100644 --- a/tests/app/http/http-tests.ts +++ b/tests/app/http/http-tests.ts @@ -9,11 +9,8 @@ export var test_getString_isDefined = function () { }; export var test_getString = function (done: (err: Error, res?: string) => void) { - var result; - http.getString("https://httpbin.org/get").then(function (r) { //// Argument (r) is string! - result = r; done(null); }, function (e) { //// Argument (e) is Error! @@ -22,13 +19,7 @@ export var test_getString = function (done: (err: Error, res?: string) => void) }; export var test_getString_fail = function (done) { - var result; - var completed: boolean; - var isReady = function () { return completed; } - http.getString({ url: "hgfttp://httpbin.org/get", method: "GET", timeout: 2000 }).catch(function (e) { - completed = true; - result = e; done(null) }); }; @@ -330,7 +321,7 @@ export var test_request_responseStatusCodeShouldBeDefined = function (done) { var statusCode = response.statusCode; result = response; try { - TKUnit.assert(typeof (result.statusCode) !== "undefined", "response.statusCode should be defined!"); + TKUnit.assert(typeof (statusCode) !== "undefined", "response.statusCode should be defined!"); done(null); } catch (err) { @@ -384,9 +375,6 @@ export var test_request_responseContentShouldBeDefined = function (done) { http.request({ url: "https://httpbin.org/get", method: "GET" }).then(function (response) { //// Argument (response) is HttpResponse! //// Content property of the response is HttpContent! - var str = response.content.toString(); - var obj = response.content.toJSON(); - var img = response.content.toImage(); result = response; try { TKUnit.assert(typeof (result.content) !== "undefined", "response.content should be defined!"); diff --git a/tests/app/image-source/image-source-tests.ts b/tests/app/image-source/image-source-tests.ts index 63f9ba8d6..712015d3d 100644 --- a/tests/app/image-source/image-source-tests.ts +++ b/tests/app/image-source/image-source-tests.ts @@ -3,7 +3,6 @@ import * as imageAssetModule from "tns-core-modules/image-asset"; import * as fs from "tns-core-modules/file-system"; import * as app from "tns-core-modules/application"; import * as TKUnit from "../tk-unit"; -import * as platform from "tns-core-modules/platform"; const imagePath = "~/assets/logo.png"; const splashscreenPath = "~/assets/splashscreen.png"; @@ -86,7 +85,7 @@ export function testFromAssetFileNotFound(done) { keepAspectRatio: true }; - let img = imageSource.fromAsset(asset).then((source) => { + imageSource.fromAsset(asset).then((source) => { done("Should not resolve with invalid file name."); }, (error) => { TKUnit.assertNotNull(error); @@ -102,7 +101,7 @@ export function testFromAssetSimple(done) { keepAspectRatio: true }; - let img = imageSource.fromAsset(asset).then((source) => { + imageSource.fromAsset(asset).then((source) => { TKUnit.assertEqual(source.width, splashscreenWidth); TKUnit.assertEqual(source.height, splashscreenHeight); done(); @@ -157,7 +156,7 @@ export function testFromAssetWithScalingAndAspectRatio(done) { keepAspectRatio: true }; - let img = imageSource.fromAsset(asset).then((source) => { + imageSource.fromAsset(asset).then((source) => { TKUnit.assertEqual(source.width, 18); TKUnit.assertEqual(source.height, scaleHeight); done(); @@ -173,7 +172,7 @@ export function testFromAssetWithScalingAndDefaultAspectRatio(done) { asset.options.width = scaleWidth; asset.options.height = scaleHeight; - let img = imageSource.fromAsset(asset).then((source) => { + imageSource.fromAsset(asset).then((source) => { TKUnit.assertEqual(source.width, 18); TKUnit.assertEqual(source.height, scaleHeight); done(); @@ -192,7 +191,7 @@ export function testFromAssetWithBiggerScaling(done) { keepAspectRatio: false }; - let img = imageSource.fromAsset(asset).then((source) => { + imageSource.fromAsset(asset).then((source) => { TKUnit.assertEqual(source.width, scaleWidth); TKUnit.assertEqual(source.height, scaleHeight); done(); diff --git a/tests/app/navigation/navigation-tests.ts b/tests/app/navigation/navigation-tests.ts index 730fe6d67..60557ee0a 100644 --- a/tests/app/navigation/navigation-tests.ts +++ b/tests/app/navigation/navigation-tests.ts @@ -2,7 +2,6 @@ import { EventData, Page, NavigatedData } from "tns-core-modules/ui/page"; import { topmost as topmostFrame, NavigationTransition } from "tns-core-modules/ui/frame"; import { StackLayout, } from "tns-core-modules/ui/layouts/stack-layout"; -import { GridLayout, } from "tns-core-modules/ui/layouts/grid-layout"; import { Color } from "tns-core-modules/color"; import * as helper from "../ui-helper"; import * as frame from "tns-core-modules/ui/frame"; @@ -110,7 +109,7 @@ export function test_backAndForwardParentPage_nestedFrames() { back(2); TKUnit.waitUntilReady(() => topmostFrame().navigationQueueIsEmpty()); - const frameStack = frame.stack(); + const frameStack = frame._stack(); TKUnit.assertEqual(frameStack.length, 1, "There should be only one frame left in the stack"); TKUnit.assertEqual(topmostFrame().currentPage, mainTestPage, "We should be on the main test page at the end of the test."); } @@ -181,7 +180,7 @@ export function test_backToEntry_WithTransition() { function _test_ClearHistory(transition?: NavigationTransition) { let topmost = topmostFrame(); - let x = 0; + helper.navigateWithEntry({ create: pageFactory, clearHistory: true, transition: transition, animated: !!transition }); TKUnit.assertEqual(topmost.backStack.length, 0, "1.topmost.backStack.length"); TKUnit.assertEqual(topmost.canGoBack(), false, "1.topmost.canGoBack()."); @@ -239,12 +238,6 @@ export function test_ClearHistoryWithTransitionDoesNotBreakNavigation() { export function test_ClearHistoryWithTransitionDoesNotBreakNavigation_WithLocalTransition() { const topmost = topmostFrame(); - let originalCachePagesOnNavigate: boolean; - if (topmost.android) { - originalCachePagesOnNavigate = topmost.android.cachePagesOnNavigate; - topmostFrame().android.cachePagesOnNavigate = true; - } - let mainTestPage = topmost.currentPage; let mainPageFactory = function (): Page { return mainTestPage; @@ -262,10 +255,6 @@ export function test_ClearHistoryWithTransitionDoesNotBreakNavigation_WithLocalT // Go back to main helper.navigateWithEntry({ create: mainPageFactory, clearHistory: true, transition: { name: "fade", duration: 10 }, animated: true }); - if (topmost.android) { - topmostFrame().android.cachePagesOnNavigate = originalCachePagesOnNavigate; - } - TKUnit.assertEqual(topmost.currentPage, mainTestPage, "We should be on the main test page at the end of the test."); TKUnit.assertEqual(topmost.backStack.length, 0, "Back stack should be empty at the end of the test."); } @@ -478,4 +467,4 @@ function _test_Navigate_From_Page_Event_Handler(eventName: string) { helper.navigateWithEntry({ create: firstPageFactory }); TKUnit.waitUntilReady(() => secondPageNavigatedTo); -} \ No newline at end of file +} diff --git a/tests/app/navigation/transition-tests.ts b/tests/app/navigation/transition-tests.ts index 690772cfd..5da33733e 100644 --- a/tests/app/navigation/transition-tests.ts +++ b/tests/app/navigation/transition-tests.ts @@ -2,7 +2,7 @@ import * as platform from "tns-core-modules/platform"; import * as trace from "tns-core-modules/trace"; import { Color } from "tns-core-modules/color"; -import { NavigationEntry, NavigationTransition, topmost as topmostFrame } from "tns-core-modules/ui/frame"; +import { NavigationEntry, NavigationTransition } from "tns-core-modules/ui/frame"; import { Page } from "tns-core-modules/ui/page"; import { AnimationCurve } from "tns-core-modules/ui/enums" import { CustomTransition } from "./custom-transition"; @@ -27,12 +27,6 @@ function _testTransition(navigationTransition: NavigationTransition) { } export function test_Transitions() { - const topmost = topmostFrame(); - const mainTestPage = topmost.currentPage; - const mainPageFactory = function (): Page { - return mainTestPage; - }; - helper.navigate(() => { const page = new Page(); page.id = "TransitionsTestPage_MAIN" @@ -59,4 +53,4 @@ export function test_Transitions() { }); // helper.navigateWithEntry({ create: mainPageFactory, clearHistory: true, animated: false }); -} \ No newline at end of file +} diff --git a/tests/app/pages/app.ts b/tests/app/pages/app.ts deleted file mode 100644 index db3999631..000000000 --- a/tests/app/pages/app.ts +++ /dev/null @@ -1,2 +0,0 @@ -import * as application from "tns-core-modules/application"; -application.start({ moduleName: "pages/page14" }); diff --git a/tests/app/pages/navigation/pageA.ts b/tests/app/pages/navigation/pageA.ts index bf526ee01..462fc8365 100644 --- a/tests/app/pages/navigation/pageA.ts +++ b/tests/app/pages/navigation/pageA.ts @@ -6,9 +6,6 @@ import * as text from "tns-core-modules/ui/text-field"; import * as color from "tns-core-modules/color"; import * as list from "tns-core-modules/ui/list-view"; -//// Enable page caching -//frame.topmost().android.cachePagesOnNavigate = true; - export function createPage() { var page = new pages.Page(); var stack = new stackModule.StackLayout(); diff --git a/tests/app/pages/page20.ts b/tests/app/pages/page20.ts index 4181d1d8b..77c419073 100644 --- a/tests/app/pages/page20.ts +++ b/tests/app/pages/page20.ts @@ -7,5 +7,5 @@ trace.enable(); export function onTap(args: observable.EventData) { var btn =