javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: observable array reduce bug (#6219)

Browse Source 
* 5868 ObservableArray Reduce Bug

* 5868 ObservableArray Reduce Bug
tslint fixes
This commit is contained in:
Rakesh Girase
2018-08-28 11:54:02 +01:00
committed by vakrilov
parent efd5f8d9ca
commit b028dd90ac
2 changed files with 33 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
tests/app/data/observable-array-tests.ts
View File

@@ -1,6 +1,5 @@
import * as TKUnit from "../TKUnit";
import { Label } from "tns-core-modules/ui/label";
// >> observable-array-require
import { ObservableArray, ChangedData, ChangeType } from "tns-core-modules/data/observable-array";
// << observable-array-require
@@ -115,7 +114,7 @@ export const test_ObservableArray_popShouldRemoveTheLastElement = function () {
// >> (hide)
const viewBase = new Label();
viewBase.set("testProperty", 0);
viewBase.bind({ sourceProperty: "length", targetProperty: "testProperty" }, array);
viewBase.bind({sourceProperty: "length", targetProperty: "testProperty"}, array);
// << (hide)
const result = array.pop();
// << observable-array-join-pop
@@ -158,7 +157,7 @@ export const test_ObservableArray_pushShouldAppendNewElement = function () {
// >> (hide)
const viewBase = new Label();
viewBase.set("testProperty", 0);
viewBase.bind({ sourceProperty: "length", targetProperty: "testProperty" }, array);
viewBase.bind({sourceProperty: "length", targetProperty: "testProperty"}, array);
// << (hide)
const result = array.push(4);
// << observable-array-push
@@ -197,7 +196,7 @@ export const test_ObservableArray_pushShouldAppendNewElements = function () {
// >> (hide)
const viewBase = new Label();
viewBase.set("testProperty", 0);
viewBase.bind({ sourceProperty: "length", targetProperty: "testProperty" }, array);
viewBase.bind({sourceProperty: "length", targetProperty: "testProperty"}, array);
// << (hide)
const result = array.push(4, 5, 6);
// << observable-array-push-multiple
@@ -236,7 +235,7 @@ export const test_ObservableArray_pushShouldAppendNewElementsFromSourceArray = f
// >> (hide)
const viewBase = new Label();
viewBase.set("testProperty", 0);
viewBase.bind({ sourceProperty: "length", targetProperty: "testProperty" }, array);
viewBase.bind({sourceProperty: "length", targetProperty: "testProperty"}, array);
// << (hide)
const result = array.push([4, 5, 6]);
// << observable-array-push-source
@@ -283,7 +282,7 @@ export const test_ObservableArray_shiftShouldRemoveTheFirstElement = function ()
// >> (hide)
const viewBase = new Label();
viewBase.set("testProperty", 0);
viewBase.bind({ sourceProperty: "length", targetProperty: "testProperty" }, array);
viewBase.bind({sourceProperty: "length", targetProperty: "testProperty"}, array);
// << (hide)
const result = array.shift();
// << observable-array-shift
@@ -355,7 +354,7 @@ export const test_ObservableArray_spliceShouldRemoveSpecifiedNumberOfElementsSta
// >> (hide)
const viewBase = new Label();
viewBase.set("testProperty", 0);
viewBase.bind({ sourceProperty: "length", targetProperty: "testProperty" }, array);
viewBase.bind({sourceProperty: "length", targetProperty: "testProperty"}, array);
// << (hide)
const result = array.splice(1, 2);
// << observable-array-splice
@@ -431,7 +430,7 @@ export const test_ObservableArray_unshiftShouldInsertNewElementsFromTheStart = f
// >> (hide)
const viewBase = new Label();
viewBase.set("testProperty", 0);
viewBase.bind({ sourceProperty: "length", targetProperty: "testProperty" }, array);
viewBase.bind({sourceProperty: "length", targetProperty: "testProperty"}, array);
// << (hide)
const result = array.unshift(4, 5);
// << observable-array-unshift
@@ -633,6 +632,20 @@ export const test_reduce_isDefined = function () {
TKUnit.assert(typeof (array.reduce) === "function", "Method 'reduce()' should be defined!");
};
export const test_reduce_without_initial_value = function () {
const sa = [1, 2, 3];
let array: ObservableArray<number> = new ObservableArray(sa);
const result = array.reduce((a, b) => a + b);
TKUnit.assertEqual(result, 6, "ObservableArray reduce function broken when initialValue is missing");
};
export const test_reduce_with_initial_value = function () {
const sa = [1, 2, 3];
let array: ObservableArray<number> = new ObservableArray(sa);
const result = array.reduce((a, b) => a + b, 5);
TKUnit.assertEqual(result, 11, "ObservableArray reduce function broken when Initial Value is passed.");
};
export const test_reduceRight_isDefined = function () {
TKUnit.assert(typeof (array.reduceRight) === "function", "Method 'reduceRight()' should be defined!");
};