javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(android): fragment creation loaded/unloaded protection

Browse Source
This commit is contained in:
Nathan Walker
2022-03-07 09:51:06 -08:00
parent 08d5656899
commit ac2e944fd3
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/core/ui/frame/index.android.ts
View File

@@ -84,6 +84,7 @@ export class Frame extends FrameBase {
private _tearDownPending = false; private _tearDownPending = false;
private _attachedToWindow = false; private _attachedToWindow = false;
private _cachedTransitionState: TransitionState; private _cachedTransitionState: TransitionState;
private _frameCreateTimeout: NodeJS.Timeout;
constructor() { constructor() {
super(); super();
@@ -237,7 +238,7 @@ export class Frame extends FrameBase {
this.backgroundColor = this._originalBackground; this.backgroundColor = this._originalBackground;
this._originalBackground = null; this._originalBackground = null;
} }
setTimeout(() => { this._frameCreateTimeout = setTimeout(() => {
// there's a bug with nested frames where sometimes the nested fragment is not recreated at all // there's a bug with nested frames where sometimes the nested fragment is not recreated at all
// so we manually check on loaded event if the fragment is not recreated and recreate it // so we manually check on loaded event if the fragment is not recreated and recreate it
const currentEntry = this._currentEntry || this._executingContext?.entry; const currentEntry = this._currentEntry || this._executingContext?.entry;
@@ -258,6 +259,10 @@ export class Frame extends FrameBase {
onUnloaded() { onUnloaded() {
super.onUnloaded(); super.onUnloaded();
if (typeof this._frameCreateTimeout === 'number') {
clearTimeout(this._frameCreateTimeout);
this._frameCreateTimeout = null;
}
} }
private disposeCurrentFragment(): void { private disposeCurrentFragment(): void {