javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(color): support web standard #rrggbbaa format

Browse Source 
original pr credit to @farfromrefug
https://github.com/NativeScript/NativeScript/pull/8519

BREAKING CHANGE

Long standing inconsistency with color handling here.

BEFORE:

```
// #aarrggbb

const color = new Color('#ff00ff00');

Label {
    background-color: #ff00ff00;
}
```

AFTER:

```
// #rrggbbaa

const color = new Color('#00ff00ff');

Label {
    background-color: #00ff00ff;
}
```
This commit is contained in:
Nathan Walker
2021-03-06 20:27:29 -08:00
parent e9b5eb934d
commit aaeab990c8
10 changed files with 36 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
apps/automated/src/ui/button/button-tests.ts
View File

@@ -181,7 +181,7 @@ var _testNativeFontSizeFromLocal = function (views: Array<View>) {
helper.assertAreClose(actualResult, expectedFontSize, 'FontSizeFromLocal');
};
var actualColorHex = '#ffff0000';
var actualColorHex = '#ff0000ff';
var expectedNormalizedColorHex = '#FF0000';
var _testLocalColorFromCss = function (views: Array<View>) {
var button = <Button>views[0];
@@ -209,7 +209,7 @@ var _testNativeColorFromLocal = function (views: Array<View>) {
TKUnit.assert(actualResult === expectedNormalizedColorHex, 'Actual: ' + actualResult + '; Expected: ' + expectedNormalizedColorHex);
};
var actualBackgroundColorHex = '#FF00FF00';
var actualBackgroundColorHex = '#00FF00FF';
var expectedNormalizedBackgroundColorHex = '#00FF00';
var _testLocalBackgroundColorFromCss = function (views: Array<View>) {
var button = <Button>views[0];
@@ -268,7 +268,7 @@ export var test_StateHighlighted_also_fires_pressedState = function () {
helper.buildUIAndRunTest(_createButtonFunc(), function (views: Array<View>) {
var view = <Button>views[0];
var page = <Page>views[1];
var expectedColor = '#FFFF0000';
var expectedColor = '#FF0000FF';
var expectedNormalizedColor = '#FF0000';
page.css = 'button:pressed { background-color: ' + expectedColor + '; }';
@@ -285,7 +285,7 @@ export var test_StateHighlighted_also_fires_activeState = function () {
helper.buildUIAndRunTest(_createButtonFunc(), function (views: Array<View>) {
var view = <Button>views[0];
var page = <Page>views[1];
var expectedColor = '#FFFF0000';
var expectedColor = '#FF0000FF';
var expectedNormalizedColor = '#FF0000';
page.css = 'button:active { background-color: ' + expectedColor + '; }';
@@ -302,7 +302,7 @@ export var test_applying_disabled_visual_State_when_button_is_disable = function
helper.buildUIAndRunTest(_createButtonFunc(), function (views: Array<View>) {
var view = <Button>views[0];
var page = <Page>views[1];
var expectedColor = '#FFFF0000';
var expectedColor = '#FF0000FF';
var expectedNormalizedColor = '#FF0000';
page.css = 'button:disabled { background-color: ' + expectedColor + '; }';