javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): provided image source can be unintentionally disposed (#10654)

Browse Source
This commit is contained in:
Dimitris-Rafail Katsampas
2025-01-13 04:12:06 +02:00
committed by GitHub
parent 050fa3fea6
commit a883a79e3b
4 changed files with 32 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/ui/image/image-common.ts
View File

@@ -125,7 +125,9 @@ export abstract class ImageBase extends View implements ImageDefinition {
}
} else if (value instanceof ImageSource) {
// Support binding the imageSource trough the src property
this.imageSource = value;
// This will help avoid cleanup on the actual provided image source in case view gets disposed
this.imageSource = new ImageSource(value.getNativeSource());
this.isLoading = false;
} else if (value instanceof ImageAsset) {
ImageSource.fromAsset(value).then((result) => {