javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(android): WeakRef race condition on timers (#10066)

Browse Source
This commit is contained in:
Eduardo Speroni
2022-11-07 13:18:26 -03:00
committed by Nathan Walker
parent 95c3b3026d
commit a65fc06c50
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/core/timer/index.android.ts
View File

@@ -3,6 +3,10 @@
*/ */
let timeoutHandler; let timeoutHandler;
const timeoutCallbacks = {}; const timeoutCallbacks = {};
// this is needed to keep a strong reference to the callback
// currently fixes a race condition in V8 with the android runtime implementation of WeakRef
// there are fixes in the android runtime that will remove the need for this
const timeoutCallbacksCb = {};
let timerId = 0; let timerId = 0;
function createHandlerAndGetId(): number { function createHandlerAndGetId(): number {
@@ -29,12 +33,14 @@ export function setTimeout(callback: Function, milliseconds = 0, ...args): numbe
if (timeoutCallbacks[id]) { if (timeoutCallbacks[id]) {
delete timeoutCallbacks[id]; delete timeoutCallbacks[id];
delete timeoutCallbacksCb[id];
} }
}, },
}); });
if (!timeoutCallbacks[id]) { if (!timeoutCallbacks[id]) {
timeoutCallbacks[id] = runnable; timeoutCallbacks[id] = runnable;
timeoutCallbacksCb[id] = callback;
} }
timeoutHandler.postDelayed(runnable, long(milliseconds)); timeoutHandler.postDelayed(runnable, long(milliseconds));
@@ -47,6 +53,7 @@ export function clearTimeout(id: number): void {
if (timeoutCallbacks[index]) { if (timeoutCallbacks[index]) {
timeoutHandler.removeCallbacks(timeoutCallbacks[index]); timeoutHandler.removeCallbacks(timeoutCallbacks[index]);
delete timeoutCallbacks[index]; delete timeoutCallbacks[index];
delete timeoutCallbacksCb[index];
} }
} }
@@ -74,6 +81,7 @@ export function setInterval(callback: Function, milliseconds = 0, ...args): numb
if (!timeoutCallbacks[id]) { if (!timeoutCallbacks[id]) {
timeoutCallbacks[id] = runnable; timeoutCallbacks[id] = runnable;
timeoutCallbacksCb[id] = callback;
} }
timeoutHandler.postDelayed(runnable, long(nextCallMs())); timeoutHandler.postDelayed(runnable, long(nextCallMs()));