javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 02:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(bottom-navigation-android): crash when changing tab and suspending app (#8030)

Browse Source
This commit is contained in:
Martin Yankov
2019-10-29 17:01:05 +02:00
committed by Manol Donev
parent 85b92b0136
commit a61de80a35
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
nativescript-core/ui/bottom-navigation/bottom-navigation.android.ts
View File

@ -380,10 +380,8 @@ export class BottomNavigation extends TabNavigationBase {
this._bottomNavigationBar.setVisibility(android.view.View.GONE); this._bottomNavigationBar.setVisibility(android.view.View.GONE);
} }
if (this._attachedToWindow) {
this.changeTab(this.selectedIndex); this.changeTab(this.selectedIndex);
} }
}
_onAttachedToWindow(): void { _onAttachedToWindow(): void {
super._onAttachedToWindow(); super._onAttachedToWindow();
@ -467,8 +465,9 @@ export class BottomNavigation extends TabNavigationBase {
// TODO: Should we extract adapter-like class? // TODO: Should we extract adapter-like class?
// TODO: Rename this? // TODO: Rename this?
public changeTab(index: number) { public changeTab(index: number) {
// this is the case when there are no items // index is -1 when there are no items
if (index === -1) { // bot nav is not attached if you change the tab too early
if (index === -1 || !this._attachedToWindow) {
return; return;
} }