javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 11:01:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

Updated weak event listener tests for v8 6.5 (#5697)

Browse Source 
* Updated weak event listener tests for v8 6.5

* added missing parentheses
This commit is contained in:
Vasil Trifonov
2018-04-18 16:57:26 +03:00
committed by dtopuzov
parent b9806bad1c
commit a616dbb9bb
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/app/ui/core/weak-event-listener/weak-event-listener-tests.ts
View File

@ -101,9 +101,13 @@ export function test_listenerDoesNotRetainTarget(done) {
const sourceRef = getSourceAsWeakRef(); const sourceRef = getSourceAsWeakRef();
const targetRef = getTargetAsWeakRef(); const targetRef = getTargetAsWeakRef();
addWeakEventListener(sourceRef.get(), Observable.propertyChangeEvent, emptyHandler, targetRef.get()); // with the v8 6.5 the GC does not release WeakRefs so fast if you pass them to a method
// that's why we are making the call to the addWeakEventListener in a closure so that the WeakRef will be easier released
(function() {
addWeakEventListener(sourceRef.get(), Observable.propertyChangeEvent, emptyHandler, targetRef.get());
})();
forceGC(); forceGC();
try { try {
TKUnit.assert(!targetRef.get(), "Target should be released after GC"); TKUnit.assert(!targetRef.get(), "Target should be released after GC");
done(null); done(null);
@ -117,7 +121,11 @@ export function test_listenerDoesNotRetainSource(done) {
const sourceRef = getSourceAsWeakRef(); const sourceRef = getSourceAsWeakRef();
const targetRef = getTargetAsWeakRef(); const targetRef = getTargetAsWeakRef();
addWeakEventListener(sourceRef.get(), Observable.propertyChangeEvent, targetRef.get().onEvent, targetRef.get()); // with the v8 6.5 the GC does not release WeakRefs so fast if you pass them to a method
// that's why we are making the call to the addWeakEventListener in a closure so that the WeakRef will be easier released
(function() {
addWeakEventListener(sourceRef.get(), Observable.propertyChangeEvent, targetRef.get().onEvent, targetRef.get());
})();
forceGC(); forceGC();
try { try {