javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor(stack-layout): add warning when measuring scrollable child (#161)

Browse Source 
* refactor(stack-layout): add warning when measuring scrollable child

* refactor: text align
This commit is contained in:
Alexander Djenkov
2019-02-08 11:15:07 +02:00
committed by Alexander Vakrilov
parent 65eb1c9c0e
commit a35c0a0340
1 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
android/widgets/src/main/java/org/nativescript/widgets/StackLayout.java
View File

@@ -7,13 +7,14 @@ import android.annotation.SuppressLint;
import android.content.Context; import android.content.Context;
import android.view.Gravity; import android.view.Gravity;
import android.view.View; import android.view.View;
import android.util.Log;
/** /**
* @author hhristov * @author hhristov
* *
*/ */
public class StackLayout extends LayoutBase { public class StackLayout extends LayoutBase {
static final String TAG = "JS";
private int _totalLength = 0; private int _totalLength = 0;
private Orientation _orientation = Orientation.vertical; private Orientation _orientation = Orientation.vertical;
@@ -80,7 +81,15 @@ public class StackLayout extends LayoutBase {
} }
if (isVertical) { if (isVertical) {
CommonLayoutParams.measureChild(child, childMeasureSpec, MeasureSpec.makeMeasureSpec(remainingLength, measureSpecMode)); // Measuring android.widget.ListView, with no height property set, with MeasureSpec.AT_MOST will
// result in height required for all list view items or the maximum available space for the StackLayout.
// Any following controls will be visible only if enough space left.
CommonLayoutParams.measureChild(child, childMeasureSpec, MeasureSpec.makeMeasureSpec(remainingLength, measureSpecMode));
if(measureSpecMode == MeasureSpec.AT_MOST && this.isUnsizedScrollableView(child)){
Log.e(TAG, "Avoid using ListView or ScrollView with no explicit height set inside StackLayout. Doing so might results in poor user interface performance and a poor user experience.");
}
final int childMeasuredWidth = CommonLayoutParams.getDesiredWidth(child); final int childMeasuredWidth = CommonLayoutParams.getDesiredWidth(child);
final int childMeasuredHeight = CommonLayoutParams.getDesiredHeight(child); final int childMeasuredHeight = CommonLayoutParams.getDesiredHeight(child);
@@ -213,4 +222,14 @@ public class StackLayout extends LayoutBase {
childLeft += childWidth; childLeft += childWidth;
} }
} }
}
private boolean isUnsizedScrollableView(View child) {
LayoutParams childLayoutParams = child.getLayoutParams();
if (childLayoutParams.height == -1 && (child instanceof android.widget.ListView || child instanceof org.nativescript.widgets.VerticalScrollView)) {
return true;
}
return false;
}
}