javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-14 18:12:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

revert: "perf(core): avoid setting the same value to view properties" (#10618)

Browse Source 
Revert "perf(core): avoid setting the same value to view properties (#10602)"

This reverts commit 499fe8dc82db623550a38d3f91eb9f9252304e31.
This commit is contained in:
Dimitris-Rafail Katsampas
2024-10-23 23:14:04 +03:00
committed by GitHub
parent e92ef33885
commit a320ca1fb3
1 changed files with 9 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
packages/core/ui/styling/style-scope.ts
View File

@ -721,40 +721,25 @@ export class CssState {
cssExpsProperties[property] = value; cssExpsProperties[property] = value;
continue; continue;
} }
delete oldProperties[property];
if (property in oldProperties) { if (property in oldProperties && oldProperties[property] === value) {
const oldValue = oldProperties[property]; // Skip unchanged values
continue;
delete oldProperties[property];
if (oldValue === value) {
// Skip unchanged values
continue;
}
} }
if (isCssVariable(property)) { if (isCssVariable(property)) {
view.style.setScopedCssVariable(property, value); view.style.setScopedCssVariable(property, value);
delete newPropertyValues[property]; delete newPropertyValues[property];
continue; continue;
} }
valuesToApply[property] = value; valuesToApply[property] = value;
} }
//we need to parse CSS vars first before evaluating css expressions
// we need to parse CSS vars first before evaluating css expressions
for (const property in cssExpsProperties) { for (const property in cssExpsProperties) {
delete oldProperties[property];
const value = evaluateCssExpressions(view, property, cssExpsProperties[property]); const value = evaluateCssExpressions(view, property, cssExpsProperties[property]);
if (property in oldProperties && oldProperties[property] === value) {
if (property in oldProperties) { // Skip unchanged values
const oldValue = oldProperties[property]; continue;
delete oldProperties[property];
if (oldValue === value) {
// Skip unchanged values
continue;
}
} }
if (value === unsetValue) { if (value === unsetValue) {
delete newPropertyValues[property]; delete newPropertyValues[property];
@ -776,11 +761,9 @@ export class CssState {
view[camelCasedProperty] = unsetValue; view[camelCasedProperty] = unsetValue;
} }
} }
// Set new values to the style // Set new values to the style
for (const property in valuesToApply) { for (const property in valuesToApply) {
const value = valuesToApply[property]; const value = valuesToApply[property];
try { try {
if (property in view.style) { if (property in view.style) {
view.style[`css:${property}`] = value; view.style[`css:${property}`] = value;