From 9b399b89f80071d4c85e3812ea8684963bf6cd3d Mon Sep 17 00:00:00 2001 From: Nathan Walker Date: Thu, 16 Mar 2023 16:35:17 -0700 Subject: [PATCH] chore: cleanup apis --- apps/toolbox/src/pages/transitions.ts | 20 +- apps/toolbox/src/pages/transitions.xml | 8 +- .../pages/transitions/transitions-modal.ts | 2 - packages/core/ui/core/view/index.android.ts | 24 +- packages/core/ui/core/view/index.ios.ts | 5 +- packages/core/ui/frame/frame-common.ts | 4 +- packages/core/ui/frame/index.android.ts | 6 +- packages/core/ui/frame/index.ios.ts | 187 ++++++++++++- .../core/ui/transition/fade-transition.d.ts | 4 +- packages/core/ui/transition/index.android.ts | 8 - packages/core/ui/transition/index.d.ts | 13 +- packages/core/ui/transition/index.ios.ts | 37 --- .../ui/transition/modal-transition.android.ts | 67 +---- .../ui/transition/modal-transition.ios.ts | 248 ++++++++++-------- .../ui/transition/page-transition.android.ts | 34 ++- .../core/ui/transition/page-transition.ios.ts | 233 +++++++++------- .../core/ui/transition/shared-transition.ts | 61 ++++- .../ui/transition/slide-transition.android.ts | 2 +- .../core/ui/transition/slide-transition.d.ts | 2 +- packages/core/utils/native-helper.d.ts | 35 +++ packages/core/utils/native-helper.ios.ts | 80 ++++++ 21 files changed, 687 insertions(+), 393 deletions(-) diff --git a/apps/toolbox/src/pages/transitions.ts b/apps/toolbox/src/pages/transitions.ts index 6859885a2..79c352769 100644 --- a/apps/toolbox/src/pages/transitions.ts +++ b/apps/toolbox/src/pages/transitions.ts @@ -9,17 +9,19 @@ export function navigatingTo(args: EventData) { // class SampleCustomModalTransition extends ModalTransition implements TransitionType { // } +SharedTransition.DEBUG = true; export class TransitionsModel extends Observable { open() { page.frame.navigate({ moduleName: `pages/transitions/transitions-detail`, transition: SharedTransition.custom(new PageTransition(), { - toPageStart: { - duration: 1000, - }, - fromPageEnd: { - duration: 500, - }, + interactiveDismissal: true, + // toPageStart: { + // duration: 400, + // }, + // fromPageEnd: { + // duration: 500, + // }, }), }); } @@ -30,15 +32,15 @@ export class TransitionsModel extends Observable { interactiveDismissal: true, toPageStart: { y: 200, - duration: 1000, + // duration: 400, }, fromPageEnd: { y: 100, - duration: 500, + // duration: 500, }, }), closeCallback(args) { - console.log('close modal callback', args); + // console.log('close modal callback', args); }, } as ShowModalOptions); } diff --git a/apps/toolbox/src/pages/transitions.xml b/apps/toolbox/src/pages/transitions.xml index ade477f7b..eca284641 100644 --- a/apps/toolbox/src/pages/transitions.xml +++ b/apps/toolbox/src/pages/transitions.xml @@ -14,10 +14,10 @@