javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 19:26:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): prevent circular reference Frame <> Page (#9111)

Browse Source
This commit is contained in:
Martin Guillon
2020-12-30 16:58:14 +01:00
committed by GitHub
parent 9aad2dbdbc
commit 9a380cd43e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/ui/page/page-common.ts
View File

@ -6,7 +6,7 @@ import { Property, CssProperty } from '../core/properties';
import { Style } from '../styling/style'; import { Style } from '../styling/style';
import { Color } from '../../color'; import { Color } from '../../color';
import { EventData } from '../../data/observable'; import { EventData } from '../../data/observable';
import { Frame } from '../frame'; import type { Frame } from '../frame';
import { ActionBar } from '../action-bar'; import { ActionBar } from '../action-bar';
import { KeyframeAnimationInfo } from '../animation/keyframe-animation'; import { KeyframeAnimationInfo } from '../animation/keyframe-animation';
import { profile } from '../../profiling'; import { profile } from '../../profiling';
@ -94,7 +94,7 @@ export class PageBase extends ContentView {
get frame(): Frame { get frame(): Frame {
const frame = this.parent; const frame = this.parent;
return frame instanceof Frame ? frame : undefined; return (frame && frame.constructor.name === 'Frame') ? frame as Frame : undefined;
} }
private createNavigatedData(eventName: string, isBackNavigation: boolean): NavigatedData { private createNavigatedData(eventName: string, isBackNavigation: boolean): NavigatedData {