javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed crash when ListView is used in a modal dialog (Android).

Browse Source
This commit is contained in:
Nedyalko Nikolov
2016-06-07 14:27:44 +03:00
parent 743a2efb4a
commit 98a9680bce
2 changed files with 42 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tns-core-modules/ui/list-view/list-view.android.ts
View File

@@ -108,7 +108,10 @@ export class ListView extends common.ListView {
callback(view);
}
else {
callback(view.parent);
// in some cases (like item is unloaded from another place (like angular) view.parent becomes undefined)
if (view.parent) {
callback(view.parent);
}
}
});
}
@@ -124,12 +127,13 @@ export class ListView extends common.ListView {
private clearRealizedCells(): void {
// clear the cache
this._realizedItems.forEach((view, nativeView, map) => {
// This is to clear the StackLayout that is used to wrap non LayoutBase & ProxyViewContainer instances.
if (!(view.parent instanceof ListView)) {
this._removeView(view.parent);
if (view.parent) {
// This is to clear the StackLayout that is used to wrap non LayoutBase & ProxyViewContainer instances.
if (!(view.parent instanceof ListView)) {
this._removeView(view.parent);
}
view.parent._removeView(view);
}
view.parent._removeView(view);
});
this._realizedItems.clear();