javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-14 18:12:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(webpack): angular 16 build with terser (#10302)

Browse Source
This commit is contained in:
Eduardo Speroni
2023-06-06 11:54:25 -03:00
committed by GitHub
parent f64355ba7a
commit 9627a80f27
2 changed files with 31 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/webpack5/__tests__/configuration/__snapshots__/angular.spec.ts.snap
View File

@ -318,7 +318,10 @@ exports[`angular configuration for android 1`] = `
keep_infinity: true, keep_infinity: true,
drop_console: false, drop_console: false,
global_defs: { global_defs: {
__UGLIFIED__: true __UGLIFIED__: true,
ngDevMode: false,
ngI18nClosureMode: false,
ngJitMode: false
} }
}, },
keep_fnames: true, keep_fnames: true,
@ -741,7 +744,10 @@ exports[`angular configuration for ios 1`] = `
keep_infinity: true, keep_infinity: true,
drop_console: false, drop_console: false,
global_defs: { global_defs: {
__UGLIFIED__: true __UGLIFIED__: true,
ngDevMode: false,
ngI18nClosureMode: false,
ngJitMode: false
} }
}, },
keep_fnames: true, keep_fnames: true,

23
packages/webpack5/src/configuration/angular.ts
View File

@ -13,6 +13,16 @@ import {
getPlatformName, getPlatformName,
} from '../helpers/platform'; } from '../helpers/platform';
import base from './base'; import base from './base';
// until we can switch to async/await on the webpack config, copy this from '@angular/compiler-cli'
const GLOBAL_DEFS_FOR_TERSER = {
ngDevMode: false,
ngI18nClosureMode: false,
};
const GLOBAL_DEFS_FOR_TERSER_WITH_AOT = {
...GLOBAL_DEFS_FOR_TERSER,
ngJitMode: false,
};
export default function (config: Config, env: IWebpackEnv = _env): Config { export default function (config: Config, env: IWebpackEnv = _env): Config {
base(config, env); base(config, env);
@ -269,6 +279,19 @@ export default function (config: Config, env: IWebpackEnv = _env): Config {
]) ])
); );
config.optimization.minimizer('TerserPlugin').tap((args) => {
args[0].terserOptions ??= {};
args[0].terserOptions.compress ??= {};
args[0].terserOptions.compress.global_defs ??= {};
args[0].terserOptions.compress.global_defs = {
...args[0].terserOptions.compress.global_defs,
...(disableAOT
? GLOBAL_DEFS_FOR_TERSER
: GLOBAL_DEFS_FOR_TERSER_WITH_AOT),
};
return args;
});
// todo: re-visit later, disabling by default now // todo: re-visit later, disabling by default now
// config.plugin('DefinePlugin').tap((args) => { // config.plugin('DefinePlugin').tap((args) => {
// args[0] = merge(args[0], { // args[0] = merge(args[0], {