javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2255 from NativeScript/transitions

Browse Source 
More transition fixes and optimizations
This commit is contained in:
Rossen Hristov
2016-06-07 10:28:02 +03:00
parent 1ad23a3a78 bab2bb13d0
commit 95b521e53b
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tns-core-modules/ui/frame/frame.android.ts
View File

@@ -236,7 +236,7 @@ export class Frame extends frameCommon.Frame {
// This bug is fixed on API19+ // This bug is fixed on API19+
ensureAnimationFixed(); ensureAnimationFixed();
let trans: number; let trans: number;
if (this.android.cachePagesOnNavigate && animationFixed < 0) { if (this.android.cachePagesOnNavigate && animationFixed < 0 && !navigationTransition) {
// Apparently, there is an Android bug with when hiding fragments with animation. // Apparently, there is an Android bug with when hiding fragments with animation.
// https://code.google.com/p/android/issues/detail?id=32405 // https://code.google.com/p/android/issues/detail?id=32405
// When bug is fixed use animated variable. // When bug is fixed use animated variable.

1
tns-core-modules/ui/transition/transition.android.ts
View File

@@ -402,6 +402,7 @@ export function _removePageNativeViewFromAndroidParent(page: Page): void {
if (trace.enabled) { if (trace.enabled) {
trace.write(`REMOVED ${page}._nativeView from its Android parent`, trace.categories.Transition); trace.write(`REMOVED ${page}._nativeView from its Android parent`, trace.categories.Transition);
} }
page._onDetached(true);
androidParent.removeView(page._nativeView); androidParent.removeView(page._nativeView);
} }
} }