javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-17 04:41:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

number now can be set as id in android

Browse Source
This commit is contained in:
Vladimir Enchev
2016-09-20 11:47:15 +03:00
parent 211f5da7f4
commit 936df853ff
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/app/ui/view/view-tests-common.ts
View File

@ -113,6 +113,12 @@ export var test_domId_IsUnique = function () {
TKUnit.assert(btn._domId !== topframe.currentPage._domId); TKUnit.assert(btn._domId !== topframe.currentPage._domId);
} }
export var test_Id_WillNotCrash_WhenSetToNumber = function () {
var btn = new button.Button();
btn.id = "1";
TKUnit.assert(btn.id === "1");
}
export var test_event_LoadedUnloaded_IsRaised = function () { export var test_event_LoadedUnloaded_IsRaised = function () {
var test = function (views: Array<viewModule.View>) { var test = function (views: Array<viewModule.View>) {
var i; var i;

2
tns-core-modules/ui/core/view.android.ts
View File

@ -26,7 +26,7 @@ function onAutomationTextPropertyChanged(data: dependencyObservable.PropertyChan
function onIdPropertyChanged(data: dependencyObservable.PropertyChangeData) { function onIdPropertyChanged(data: dependencyObservable.PropertyChangeData) {
var view = <View>data.object; var view = <View>data.object;
view._nativeView.setTag(data.newValue); view._nativeView.setTag(data.newValue + "");
} }
(<proxy.PropertyMetadata>viewCommon.View.idProperty.metadata).onSetNativeValue = onIdPropertyChanged; (<proxy.PropertyMetadata>viewCommon.View.idProperty.metadata).onSetNativeValue = onIdPropertyChanged;