javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-17 21:01:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7534 from NativeScript/djenkov/limit-bottom-navigation-items

Browse Source 
feat(bottom-navigation-ios): limit bottom to 5 items
This commit is contained in:
Svetoslav
2019-07-24 14:10:26 +03:00
committed by GitHub
parent 49ab3646e7 530e97b974
commit 92238a902d
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tns-core-modules/ui/bottom-navigation/bottom-navigation.ios.ts
View File

@ -21,6 +21,7 @@ export * from "../tab-navigation-base/tab-navigation-base";
export * from "../tab-navigation-base/tab-strip"; export * from "../tab-navigation-base/tab-strip";
export * from "../tab-navigation-base/tab-strip-item"; export * from "../tab-navigation-base/tab-strip-item";
const maxTabsCount = 5;
const majorVersion = iosUtils.MajorVersion; const majorVersion = iosUtils.MajorVersion;
const isPhone = device.deviceType === "Phone"; const isPhone = device.deviceType === "Phone";
@ -490,6 +491,9 @@ export class BottomNavigation extends TabNavigationBase {
return; return;
} }
// Limit both tabContentItems and tabStripItems to 5 in order to prevent iOS 'more' button
items = items.slice(0, maxTabsCount);
const controllers = NSMutableArray.alloc<UIViewController>().initWithCapacity(length); const controllers = NSMutableArray.alloc<UIViewController>().initWithCapacity(length);
const states = getTitleAttributesForStates(this); const states = getTitleAttributesForStates(this);