javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-16 11:42:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8380 from NathanaelA/fix_css_styles

Browse Source 
fix(css): parse issue with new Webpacked AST css/scss files
This commit is contained in:
Dimitar Topuzov
2020-03-10 18:15:04 +02:00
committed by GitHub
parent 64fc3e020c b13f4d058c
commit 916ec8b1a0
1 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
nativescript-core/ui/styling/style-scope.ts
View File

@ -110,6 +110,19 @@ class CSSSource {
this.parse(); this.parse();
} }
public static fromDetect(cssOrAst: any, keyframes: KeyframesMap, fileName?: string): CSSSource {
if (typeof cssOrAst === "string") {
// raw-loader
return CSSSource.fromSource(cssOrAst, keyframes, fileName);
} else if (typeof cssOrAst === "object" && cssOrAst.type === "stylesheet" && cssOrAst.stylesheet && cssOrAst.stylesheet.rules) {
// css-loader
return CSSSource.fromAST(cssOrAst, keyframes, fileName);
} else {
// css2json-loader
return CSSSource.fromSource(cssOrAst.toString(), keyframes, fileName);
}
}
public static fromURI(uri: string, keyframes: KeyframesMap): CSSSource { public static fromURI(uri: string, keyframes: KeyframesMap): CSSSource {
// webpack modules require all file paths to be relative to /app folder // webpack modules require all file paths to be relative to /app folder
const appRelativeUri = CSSSource.pathRelativeToApp(uri); const appRelativeUri = CSSSource.pathRelativeToApp(uri);
@ -119,16 +132,7 @@ class CSSSource {
try { try {
const cssOrAst = global.loadModule(resolvedModuleName, true); const cssOrAst = global.loadModule(resolvedModuleName, true);
if (cssOrAst) { if (cssOrAst) {
if (typeof cssOrAst === "string") { return CSSSource.fromDetect(cssOrAst, keyframes, resolvedModuleName);
// raw-loader
return CSSSource.fromSource(cssOrAst, keyframes, resolvedModuleName);
} else if (typeof cssOrAst === "object" && cssOrAst.type === "stylesheet" && cssOrAst.stylesheet && cssOrAst.stylesheet.rules) {
// css-loader
return CSSSource.fromAST(cssOrAst, keyframes, resolvedModuleName);
} else {
// css2json-loader
return CSSSource.fromSource(cssOrAst.toString(), keyframes, resolvedModuleName);
}
} }
} catch (e) { } catch (e) {
traceWrite(`Could not load CSS from ${uri}: ${e}`, traceCategories.Error, traceMessageType.error); traceWrite(`Could not load CSS from ${uri}: ${e}`, traceCategories.Error, traceMessageType.error);
@ -325,7 +329,7 @@ export function removeTaggedAdditionalCSS(tag: String | Number): Boolean {
} }
export function addTaggedAdditionalCSS(cssText: string, tag?: string | Number): Boolean { export function addTaggedAdditionalCSS(cssText: string, tag?: string | Number): Boolean {
const parsed: RuleSet[] = CSSSource.fromSource(cssText, applicationKeyframes, undefined).selectors; const parsed: RuleSet[] = CSSSource.fromDetect(cssText, applicationKeyframes, undefined).selectors;
let changed = false; let changed = false;
if (parsed && parsed.length) { if (parsed && parsed.length) {
changed = true; changed = true;