From 8be543bcc7da2634f9c627ea15b06e6dfef78b93 Mon Sep 17 00:00:00 2001 From: Nathan Walker Date: Tue, 8 Mar 2022 14:25:05 -0800 Subject: [PATCH] feat: testID property for use with e2e testing without interfering with a11y (#9793) * fix(android): nested frames were sometimes not recreated (#9748) Co-authored-by: Eduardo Speroni * feat: testID property for use with e2e testing without interfering with a11y * feat: better testID support along a11y wip * fix: make sure we have a defined id * feat: --env.e2e to enable testID * chore: return if using testID * chore: cleanup Co-authored-by: Eduardo Speroni Co-authored-by: Igor Randjelovic --- apps/toolbox/src/pages/a11y.xml | 24 +++++++------- packages/core/accessibility/index.android.ts | 5 +++ packages/core/global-types.d.ts | 1 + .../core/platforms/android/res/values/ids.xml | 4 +++ packages/core/ui/core/view/index.android.ts | 31 ++++++++++++++++--- packages/core/ui/core/view/index.ios.ts | 19 ++++++++++-- packages/core/ui/core/view/view-common.ts | 11 +++++++ packages/core/ui/text-base/index.android.ts | 21 +++++++++---- .../__snapshots__/angular.spec.ts.snap | 6 ++-- .../__snapshots__/base.spec.ts.snap | 6 ++-- .../__snapshots__/javascript.spec.ts.snap | 6 ++-- .../__snapshots__/react.spec.ts.snap | 4 +++ .../__snapshots__/svelte.spec.ts.snap | 6 ++-- .../__snapshots__/typescript.spec.ts.snap | 6 ++-- .../__snapshots__/vue.spec.ts.snap | 6 ++-- packages/webpack5/src/configuration/base.ts | 3 ++ packages/webpack5/src/index.ts | 1 + 17 files changed, 123 insertions(+), 37 deletions(-) create mode 100644 packages/core/platforms/android/res/values/ids.xml diff --git a/apps/toolbox/src/pages/a11y.xml b/apps/toolbox/src/pages/a11y.xml index 1cf029804..d8c62cb36 100644 --- a/apps/toolbox/src/pages/a11y.xml +++ b/apps/toolbox/src/pages/a11y.xml @@ -7,25 +7,25 @@ -