javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Made TabViewItem bindable.

Browse Source
This commit is contained in:
Rossen Hristov
2015-08-28 12:43:16 +03:00
parent db8b1172f9
commit 881c378a4e
7 changed files with 84 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/tests/app/pageNavigation.ts
View File

@@ -15,10 +15,10 @@ export function createPage() {
topFrame.goBack();
});
tab.items.push({
tab.items.push(new tabViewModule.TabViewItem({
title: "Tab " + i,
view: button
});
}));
}
var page = new pages.Page();
page.content = tab;

5
apps/tests/ui/style/style-tests.ts
View File

@@ -47,10 +47,7 @@ export function test_css_is_applied_inside_TabView() {
var testButton = new buttonModule.Button();
testButton.text = "Test";
var tabView = new tabViewModule.TabView();
tabView.items = [{
title: "First tab",
view: testButton
}];
tabView.items = [new tabViewModule.TabViewItem({ title: "First tab", view: testButton })];
helper.buildUIAndRunTest(tabView, function (views: Array<viewModule.View>) {
var page = <pageModule.Page>views[1];

12
apps/tests/ui/tab-view/tab-view-tests.ts
View File

@@ -57,10 +57,10 @@ function _createItems(count: number): Array<tabViewModule.TabViewItem> {
for (var i = 0; i < count; i++) {
var label = new labelModule.Label();
label.text = "Tab " + i;
var tabEntry = {
var tabEntry = new tabViewModule.TabViewItem({
title: "Tab " + i,
view: label
};
});
items.push(tabEntry);
}
return items;
@@ -267,7 +267,7 @@ export var testBindingToTabEntryWithUndefinedViewShouldThrow = function () {
helper.buildUIAndRunTest(tabView, function (views: Array<viewModule.View>) {
var tabView = <tabViewModule.TabView>views[0];
TKUnit.assertThrows(function () {
tabView.items = [{ title: "Tab 0", view: undefined }];
tabView.items = [new tabViewModule.TabViewItem({ title: "Tab 0", view: undefined })];
}, "Binding TabView to a TabViewItem with undefined view should throw.");
});
}
@@ -277,7 +277,7 @@ export var testBindingToTabEntryWithNullViewShouldThrow = function () {
helper.buildUIAndRunTest(tabView, function (views: Array<viewModule.View>) {
var tabView = <tabViewModule.TabView>views[0];
TKUnit.assertThrows(function () {
tabView.items = [{ title: "Tab 0", view: null }];
tabView.items = [new tabViewModule.TabViewItem({ title: "Tab 0", view: null })];
}, "Binding TabView to a TabViewItem with null view should throw.");
});
}
@@ -462,10 +462,10 @@ export function testBindingIsRefreshedWhenTabViewItemIsUnselectedAndThenSelected
label0.id = "testLabel";
label0.bind({ sourceProperty: "counter", targetProperty: "text", twoWay: true });
StackLayout0.addChild(label0);
var tabEntry0 = {
var tabEntry0 = new tabViewModule.TabViewItem({
title: "Tab 0",
view: StackLayout0
};
});
items.push(tabEntry0);
tabView.items = items;