javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(tabs-ios9): no view controller managing visible view error (#7837)

Browse Source
This commit is contained in:
Manol Donev
2019-10-15 13:32:35 +03:00
committed by GitHub
parent ff30c4861f
commit 7fe8d1c339
3 changed files with 30 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/app/ui/image-cache/image-cache-tests.ts
View File

@@ -1,6 +1,7 @@
import * as imageCacheModule from "tns-core-modules/ui/image-cache";
import * as imageSource from "tns-core-modules/image-source";
import * as types from "tns-core-modules/utils/types";
import { isAndroid } from "tns-core-modules/platform";
import { device } from "tns-core-modules/platform";
import lazy from "tns-core-modules/utils/lazy";
@@ -10,7 +11,7 @@ const sdkVersion = lazy(() => parseInt(device.sdkVersion));
export const test_ImageCache_ValidUrl = function() {
// see https://github.com/NativeScript/NativeScript/issues/6643
if (sdkVersion() < 20) {
if (isAndroid && sdkVersion() < 20) {
return;
}

13
tests/app/xml-parser-tests/xml-parser-tests.ts
View File

@@ -6,6 +6,11 @@ import * as TKUnit from "../tk-unit";
import * as xmlModule from "tns-core-modules/xml";
import * as fs from "tns-core-modules/file-system";
import * as builder from "tns-core-modules/ui/builder";
import { isIOS } from "tns-core-modules/platform";
import { device } from "tns-core-modules/platform";
import lazy from "tns-core-modules/utils/lazy";
const sdkVersion = lazy(() => parseInt(device.sdkVersion));
export var test_XmlParser_IsDefined = function () {
TKUnit.assertNotEqual(xmlModule.XmlParser, undefined, "Class XmlParser should be defined!");
@@ -94,6 +99,10 @@ export var test_XmlParser_OnErrorIsCalledWhenAnErrorOccurs = function () {
};
export var test_XmlParser_IntegrationTest = function () {
if (isIOS && sdkVersion() < 10) {
return;
}
var actualResult = "";
var xmlParser = new xmlModule.XmlParser(function (event: xmlModule.ParserEvent) {
if (event.eventType === xmlModule.ParserEventType.Text && event.data.trim() === "") {
@@ -194,6 +203,10 @@ export var test_XmlParser_DummyDocumentationTest = function () {
};
export var test_XmlParser_NamespacesTest = function () {
if (isIOS && sdkVersion() < 10) {
return;
}
var xmlParser = new xmlModule.XmlParser(function (event: xmlModule.ParserEvent) {
if (event.eventType !== xmlModule.ParserEventType.StartElement) {
return;