javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 19:26:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(android): prevent error while opening modal from background (#10570)

Browse Source 
It is a known android "issue" that you cant commit/show a fragment while in background. The reason is, as explained [here](https://medium.com/@113408/avoid-fragment-illegalstateexception-can-not-perform-this-action-after-onsaveinstancestate-ba76ae4f00fe) or [here](https://stackoverflow.com/questions/15729138/on-showing-dialog-i-get-can-not-perform-this-action-after-onsaveinstancestate), that `onSaveInstanceState` is already called so any operation before activity start would be with state loss.
There are 2 solutions in this case:
* use `commitAllowingStateLoss`, `dismissAllowingStateLoss` ... but then you loose state ... This is what we are doing in N in many cases. We can do this with `show` too but we would need to override the `DialogFragment.show` method.
* delay the action until the activity is resumed.

This PR uses the second solution. We could add an option to `showModal` to use the first solution. The user experience is different. Solution 1:  when the app is resumed the modal is already shown and layed out. Solution 2: you see the modal opening on app resume
This commit is contained in:
farfromrefuge
2024-07-03 21:23:01 +02:00
committed by GitHub
parent 80f3ff2042
commit 7e9be32e28
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/core/ui/core/view/index.android.ts
View File

@ -684,6 +684,17 @@ export class View extends ViewCommon {
return result | (childMeasuredState & layout.MEASURED_STATE_MASK); return result | (childMeasuredState & layout.MEASURED_STATE_MASK);
} }
protected _showNativeModalView(parent: View, options: ShowModalOptions) { protected _showNativeModalView(parent: View, options: ShowModalOptions) {
// if the app is in background while triggering _showNativeModalView
// then DialogFragment.show will trigger IllegalStateException: Can not perform this action after onSaveInstanceState
// so if in background we create an event to call _showNativeModalView when loaded (going back in foreground)
if (Application.inBackground && !parent.isLoaded) {
const onLoaded = ()=> {
parent.off('loaded', onLoaded)
this._showNativeModalView(parent, options);
};
parent.on('loaded', onLoaded);
return;
}
super._showNativeModalView(parent, options); super._showNativeModalView(parent, options);
initializeDialogFragment(); initializeDialogFragment();