javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: memory leaks around image picking/saving to device

Browse Source
This commit is contained in:
Nathan Walker
2022-02-26 10:15:12 -08:00
parent 40c5984966
commit 7dcfecffab
5 changed files with 75 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/core/image-asset/index.ios.ts
View File

@@ -1,5 +1,6 @@
import { ImageAssetBase, getRequestedImageSize } from './image-asset-common';
import { path as fsPath, knownFolders } from '../file-system';
import { queueGC } from '../utils';
export * from './image-asset-common';
@@ -40,10 +41,8 @@ export class ImageAsset extends ImageAssetBase {
const requestedSize = getRequestedImageSize({ width: srcWidth, height: srcHeight }, this.options);
if (this.nativeImage) {
const newSize = CGSizeMake(requestedSize.width, requestedSize.height);
const resizedImage = this.scaleImage(this.nativeImage, newSize);
callback(resizedImage, null);
callback(this.scaleImage(this.nativeImage, CGSizeMake(requestedSize.width, requestedSize.height)), null);
queueGC();
return;
}
@@ -53,11 +52,11 @@ export class ImageAsset extends ImageAssetBase {
PHImageManager.defaultManager().requestImageForAssetTargetSizeContentModeOptionsResultHandler(this.ios, requestedSize, PHImageContentMode.AspectFit, imageRequestOptions, (image, imageResultInfo) => {
if (image) {
const resultImage = this.scaleImage(image, requestedSize);
callback(resultImage, null);
callback(this.scaleImage(image, requestedSize), null);
} else {
callback(null, imageResultInfo.valueForKey(PHImageErrorKey));
}
queueGC();
});
}