javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-19 14:20:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix android modal not following activity windowSoftInputMode

Browse Source 
Also added an android modal parameter to set a custom windowSoftInputMode
This commit is contained in:
Martin Guillon
2020-11-16 09:28:43 +01:00
parent 023be8cbf1
commit 7d75c6f42c
3 changed files with 34 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/ui/core/view-base/index.d.ts vendored
View File

@ -83,6 +83,10 @@ export interface ShowModalOptions {
* An optional parameter specifying whether the modal view can be dismissed when not in full-screen mode.
*/
cancelable?: boolean;
/**
* An optional parameter specifying the windowSoftInputMode of the dialog window
*/
windowSoftInputMode?: number;
};
/**
* An optional parameter specifying whether the modal view can be dismissed when not in full-screen mode.

5
packages/core/ui/core/view-base/index.ts
View File

@ -87,6 +87,11 @@ export interface ShowModalOptions {
* An optional parameter specifying whether the modal view can be dismissed when not in full-screen mode.
*/
cancelable?: boolean;
/**
* An optional parameter specifying the windowSoftInputMode of the dialog window
*/
windowSoftInputMode?: number;
};
/**
* An optional parameter specifying whether the modal view can be dismissed when not in full-screen mode.

30
packages/core/ui/core/view/index.android.ts
View File

@ -76,6 +76,7 @@ interface DialogOptions {
animated: boolean;
stretched: boolean;
cancelable: boolean;
windowSoftInputMode: number;
shownCallback: () => void;
dismissCallback: () => void;
}
@ -168,6 +169,7 @@ function initializeDialogFragment() {
class DialogFragmentImpl extends androidx.fragment.app.DialogFragment {
public owner: View;
private _fullscreen: boolean;
private _windowSoftInputMode: number;
private _animated: boolean;
private _stretched: boolean;
private _cancelable: boolean;
@ -192,6 +194,7 @@ function initializeDialogFragment() {
this._stretched = options.stretched;
this._dismissCallback = options.dismissCallback;
this._shownCallback = options.shownCallback;
this._windowSoftInputMode = options.windowSoftInputMode;
this.setStyle(androidx.fragment.app.DialogFragment.STYLE_NO_TITLE, 0);
let theme = this.getTheme();
@ -243,8 +246,20 @@ function initializeDialogFragment() {
}
const owner = this.owner;
if (owner && !owner.isLoaded) {
owner.callLoaded();
if (owner) {
if (!owner.isLoaded) {
owner.callLoaded();
}
const window = this.getDialog().getWindow();
if (this._windowSoftInputMode !== undefined) {
window.setSoftInputMode(this._windowSoftInputMode);
} else {
// the dialog seems to not follow the default activity softinputmode,
// thus set we set it here.
window.setSoftInputMode((<androidx.appcompat.app.AppCompatActivity>owner._context).getWindow().getAttributes().softInputMode);
}
}
this._shownCallback();
@ -672,10 +687,14 @@ export class View extends ViewCommon {
df.setArguments(args);
let cancelable = true;
let windowSoftInputMode: number;
if (options.android && (<any>options).android.cancelable !== undefined) {
cancelable = !!(<any>options).android.cancelable;
console.log('ShowModalOptions.android.cancelable is deprecated. Use ShowModalOptions.cancelable instead.');
if (options.android) {
if ((<any>options).android.cancelable !== undefined) {
cancelable = !!(<any>options).android.cancelable;
console.log('ShowModalOptions.android.cancelable is deprecated. Use ShowModalOptions.cancelable instead.');
}
windowSoftInputMode = (<any>options).android.windowSoftInputMode;
}
cancelable = options.cancelable !== undefined ? !!options.cancelable : cancelable;
@ -686,6 +705,7 @@ export class View extends ViewCommon {
animated: !!options.animated,
stretched: !!options.stretched,
cancelable: cancelable,
windowSoftInputMode: windowSoftInputMode,
shownCallback: () => this._raiseShownModallyEvent(),
dismissCallback: () => this.closeModal(),
};