javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-16 11:42:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(android): prevent rehydration on destroyed dialogs (#10414)

Browse Source
This commit is contained in:
Jason Cassidy
2023-10-24 01:48:57 +01:00
committed by GitHub
parent e8c093d7a2
commit 756354952c
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/core/ui/core/view/index.android.ts
View File

@ -173,7 +173,16 @@ function initializeDialogFragment() {
return global.__native(this); return global.__native(this);
} }
public onCreate(savedInstanceState: android.os.Bundle) {
super.onCreate(savedInstanceState);
var ownerId = this.getArguments()?.getInt(DOMID);
var options = getModalOptions(ownerId);
// The teardown when the activity is destroyed happens after the state is saved, but is not recoverable,
// Cancel the native dialog in this case or the app will crash with subsequent errors.
if (savedInstanceState != null && options === undefined) {
this.dismissAllowingStateLoss();
}
}
public onCreateDialog(savedInstanceState: android.os.Bundle): android.app.Dialog { public onCreateDialog(savedInstanceState: android.os.Bundle): android.app.Dialog {
const ownerId = this.getArguments().getInt(DOMID); const ownerId = this.getArguments().getInt(DOMID);
const options = getModalOptions(ownerId); const options = getModalOptions(ownerId);