javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 02:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(core): frame ignored event listeners in xml markup (#10646)

Browse Source
This commit is contained in:
Dimitris-Rafail Katsampas
2024-11-19 05:50:21 +02:00
committed by GitHub
parent 712a9f4848
commit 750d2ee455
2 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/core/ui/frame/frame-common.ts
View File

@ -35,7 +35,8 @@ function buildEntryFromArgs(arg: any): NavigationEntry {
@CSSType('Frame') @CSSType('Frame')
export class FrameBase extends CustomLayoutView { export class FrameBase extends CustomLayoutView {
public static androidOptionSelectedEvent = 'optionSelected'; public static navigatingToEvent = 'navigatingTo';
public static navigatedToEvent = 'navigatedTo';
private _animated: boolean; private _animated: boolean;
private _transition: NavigationTransition; private _transition: NavigationTransition;
@ -267,7 +268,7 @@ export class FrameBase extends CustomLayoutView {
newPage.onNavigatedTo(isBack); newPage.onNavigatedTo(isBack);
this.notify({ this.notify({
eventName: Page.navigatedToEvent, eventName: FrameBase.navigatedToEvent,
object: this, object: this,
isBack, isBack,
entry, entry,
@ -452,7 +453,7 @@ export class FrameBase extends CustomLayoutView {
backstackEntry.resolvedPage.onNavigatingTo(backstackEntry.entry.context, isBack, backstackEntry.entry.bindingContext); backstackEntry.resolvedPage.onNavigatingTo(backstackEntry.entry.context, isBack, backstackEntry.entry.bindingContext);
this.notify({ this.notify({
eventName: Page.navigatingToEvent, eventName: FrameBase.navigatingToEvent,
object: this, object: this,
isBack, isBack,
entry: backstackEntry, entry: backstackEntry,

10
packages/core/ui/frame/index.d.ts vendored
View File

@ -17,6 +17,16 @@ export interface NavigationData extends EventData {
* Nested frames are supported, enabling hierarchical navigation scenarios. * Nested frames are supported, enabling hierarchical navigation scenarios.
*/ */
export class Frame extends FrameBase { export class Frame extends FrameBase {
/**
* String value used when hooking to navigatingTo event.
*/
public static readonly navigatingToEvent = 'navigatingTo';
/**
* String value used when hooking to navigatedTo event.
*/
public static readonly navigatedToEvent = 'navigatedTo';
/** /**
* @private * @private
*/ */