From 477d0016b1cc033e66558a4079e71b2f08f4ecd0 Mon Sep 17 00:00:00 2001 From: Richard Lai Date: Tue, 24 Nov 2015 15:35:37 -0500 Subject: [PATCH 1/2] Correct TabView icon rendering mode Fixes #1148. --- ui/tab-view/tab-view.ios.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/tab-view/tab-view.ios.ts b/ui/tab-view/tab-view.ios.ts index 72f6d2af9..21a190707 100644 --- a/ui/tab-view/tab-view.ios.ts +++ b/ui/tab-view/tab-view.ios.ts @@ -243,7 +243,7 @@ export class TabView extends common.TabView { if (!image) { var is = imageSource.fromFileOrResource(iconSource); if (is && is.ios) { - is.ios.renderingMode = UIImageRenderingMode.UIImageRenderingModeAlwaysOriginal; + is.ios = is.ios.imageWithRenderingMode(UIImageRenderingMode.UIImageRenderingModeAlwaysOriginal); this._iconsCache[iconSource] = is.ios; image = is.ios; } From 2b1be2da43f49417808773903850959dc355323a Mon Sep 17 00:00:00 2001 From: Richard Lai Date: Tue, 24 Nov 2015 15:44:05 -0500 Subject: [PATCH 2/2] Name the originally-rendered image --- ui/tab-view/tab-view.ios.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/tab-view/tab-view.ios.ts b/ui/tab-view/tab-view.ios.ts index 21a190707..54038e1e9 100644 --- a/ui/tab-view/tab-view.ios.ts +++ b/ui/tab-view/tab-view.ios.ts @@ -243,9 +243,9 @@ export class TabView extends common.TabView { if (!image) { var is = imageSource.fromFileOrResource(iconSource); if (is && is.ios) { - is.ios = is.ios.imageWithRenderingMode(UIImageRenderingMode.UIImageRenderingModeAlwaysOriginal); - this._iconsCache[iconSource] = is.ios; - image = is.ios; + var originalRenderedImage = is.ios.imageWithRenderingMode(UIImageRenderingMode.UIImageRenderingModeAlwaysOriginal); + this._iconsCache[iconSource] = originalRenderedImage; + image = originalRenderedImage; } }