javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Avoid applying CSS multiple times (#4784)

Browse Source 
* Move the applyStyleFromScope to onLoaded, when the views are created and id or className properties are set the CSS selectors are queried and applied multiple times

* Condense the changes when applying properties
This commit is contained in:
Panayot Cankov
2017-09-25 18:32:00 +03:00
committed by SvetoslavTsenov
parent b0577728be
commit 6d7c1ff295
25 changed files with 536 additions and 524 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tns-core-modules/ui/builder/component-builder/component-builder.ts
View File

@@ -125,12 +125,6 @@ const applyComponentCss = profile("applyComponentCss", (instance: View, moduleNa
cssApplied = true;
}
}
if (!cssApplied) {
// Called only to apply application css.
// If we have page css (through file or cssAttribute) we have appCss applied.
(<any>instance)._refreshCss();
}
}
});
@@ -211,13 +205,7 @@ export function setPropertyValue(instance: View, instanceModule: Object, exports
instance[propertyName] = exports[propertyValue];
}
else {
let attrHandled = false;
if (!attrHandled && instance._applyXmlAttribute) {
attrHandled = instance._applyXmlAttribute(propertyName, propertyValue);
}
if (!attrHandled) {
instance[propertyName] = propertyValue;
}
instance[propertyName] = propertyValue;
}
}