From b993a83f2371df8cb276474360d95e89d62e5ad5 Mon Sep 17 00:00:00 2001 From: Dimitris-Rafail Katsampas Date: Fri, 3 Feb 2023 07:58:01 +0200 Subject: [PATCH 1/8] fix(core): added item template handling for external renderers (#10196) --- packages/core/ui/list-view/list-view-common.ts | 10 ++++++++-- packages/core/ui/repeater/index.ts | 3 ++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/packages/core/ui/list-view/list-view-common.ts b/packages/core/ui/list-view/list-view-common.ts index 25180a78f..04f1bbddb 100644 --- a/packages/core/ui/list-view/list-view-common.ts +++ b/packages/core/ui/list-view/list-view-common.ts @@ -10,6 +10,7 @@ import { Observable, EventData } from '../../data/observable'; import { ObservableArray, ChangedData } from '../../data/observable-array'; import { addWeakEventListener, removeWeakEventListener } from '../core/weak-event-listener'; import { CoreTypes } from '../../core-types'; +import { isFunction } from '../../utils/types'; const autoEffectiveRowHeight = -1; @@ -28,8 +29,13 @@ export abstract class ListViewBase extends ContainerView implements ListViewDefi key: 'default', createView: () => { if (__UI_USE_EXTERNAL_RENDERER__) { - } else if (this.itemTemplate) { - return Builder.parse(this.itemTemplate, this); + if (isFunction(this.itemTemplate)) { + return (