javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: recycle eventPath

Browse Source
This commit is contained in:
shirakaba
2022-12-18 00:41:22 +09:00
parent efb1a93287
commit 66f62fbbd6
1 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
packages/core/data/dom-events/dom-event.ts
View File

@@ -1,5 +1,4 @@
import type { EventData, ListenerEntry, Observable } from '../observable/index'; import type { EventData, ListenerEntry, Observable } from '../observable/index';
import type { ViewBase } from '../../ui/core/view-base';
import { MutationSensitiveArray } from '../mutation-sensitive-array'; import { MutationSensitiveArray } from '../mutation-sensitive-array';
// This file contains some of Core's hot paths, so attention has been taken to // This file contains some of Core's hot paths, so attention has been taken to
@@ -16,6 +15,13 @@ const timeOrigin = Date.now();
*/ */
const emptyArray = new MutationSensitiveArray<ListenerEntry>(); const emptyArray = new MutationSensitiveArray<ListenerEntry>();
/**
* Recycling the event path array rather than allocating a new one each time
* saves about 210 nanoseconds per dispatchTo() call (and avoids memory pressure
* and GC).
*/
const recycledEventPath: Observable[] = [];
export class DOMEvent implements Event { export class DOMEvent implements Event {
/** /**
* @private * @private
@@ -157,7 +163,7 @@ export class DOMEvent implements Event {
// Walk up the target's parents if it has parents (is a ViewBase or // Walk up the target's parents if it has parents (is a ViewBase or
// subclass of ViewBase) or not (is an Observable). // subclass of ViewBase) or not (is an Observable).
return this.target.isViewBase() ? this.getEventPath(this.target, 'bubble') : [this.target]; return [...this.getEventPath(this.target, 'bubble')];
} }
/** /**
@@ -170,17 +176,23 @@ export class DOMEvent implements Event {
* @example * @example
* [Button, StackLayout, Page] // 'bubble' * [Button, StackLayout, Page] // 'bubble'
*/ */
private getEventPath(responder: ViewBase, path: 'capture' | 'bubble'): ViewBase[] { private getEventPath(responder: Observable, path: 'capture' | 'bubble'): Observable[] {
const chain = [responder]; recycledEventPath.splice(0, recycledEventPath.length);
recycledEventPath.push(responder);
if (!responder.isViewBase()) {
return recycledEventPath;
}
let nextResponder = responder.parent; let nextResponder = responder.parent;
while (nextResponder) { while (nextResponder) {
path === 'capture' ? chain.unshift(nextResponder) : chain.push(nextResponder); path === 'capture' ? recycledEventPath.unshift(nextResponder) : recycledEventPath.push(nextResponder);
// TODO: decide whether to walk up from Page to Frame, and whether // TODO: decide whether to walk up from Page to Frame, and whether
// to then walk from Frame to Application or something. // to then walk from Frame to Application or something.
nextResponder = nextResponder?.parent; nextResponder = nextResponder?.parent;
} }
return chain; return recycledEventPath;
} }
/** @deprecated */ /** @deprecated */
@@ -278,7 +290,7 @@ export class DOMEvent implements Event {
phase: this.CAPTURING_PHASE, phase: this.CAPTURING_PHASE,
}); });
const eventPath = target.isViewBase() ? this.getEventPath(target, 'capture') : [target]; const eventPath = this.getEventPath(target, 'capture');
// Capturing phase, e.g. [Page, StackLayout, Button] // Capturing phase, e.g. [Page, StackLayout, Button]
for (const currentTarget of eventPath) { for (const currentTarget of eventPath) {