javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(slider): correct maxValue setter for android (#4346)

Browse Source 
The setter should invoke setNativeValuesSilently with the new value and
max value respectively.

fixes #4343
This commit is contained in:
Stanimira Vlaeva
2017-06-09 18:20:25 +03:00
committed by GitHub
parent 9bba250424
commit 618433816e
2 changed files with 106 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tns-core-modules/ui/slider/slider.android.ts
View File

@@ -80,8 +80,7 @@ export class Slider extends SliderBase {
try {
nativeView.setMax(newMaxValue);
nativeView.setProgress(newValue);
}
finally {
} finally {
this._supressNativeValue = false;
}
}
@@ -102,7 +101,7 @@ export class Slider extends SliderBase {
return 100;
}
[maxValueProperty.setNative](value: number) {
this.nativeView.setMax(value - this.minValue);
this.setNativeValuesSilently(value - this.minValue, value);
}
[colorProperty.getDefault](): number {