From 5a3b9d5e16c801c4eb005c81c3c30d16d4e17499 Mon Sep 17 00:00:00 2001 From: Martin Guillon Date: Sat, 12 Sep 2020 15:18:08 +0200 Subject: [PATCH] finish removal of Tabs component --- apps/automated/src/test-runner.ts | 9 - .../src/ui/tabs/tabs-navigation-tests.ts | 284 -------------- apps/automated/src/ui/tabs/tabs-root-tests.ts | 194 --------- .../src/ui/tabs/tabs-tests-native.android.ts | 40 -- .../src/ui/tabs/tabs-tests-native.d.ts | 8 - .../src/ui/tabs/tabs-tests-native.ios.ts | 44 --- apps/automated/src/ui/tabs/tabs-tests-new.ts | 33 -- apps/automated/src/ui/tabs/tabs-tests.ts | 350 ----------------- .../tabs/tabs-tests.e2e-spec.ts | 370 ------------------ .../tabs/tabs-view-base-page.ts | 39 -- apps/ui/src/bottom-navigation/events-page.ts | 8 +- apps/ui/src/main-page.ts | 1 - apps/ui/src/tabs/background-color-page.css | 19 - apps/ui/src/tabs/background-color-page.xml | 24 -- apps/ui/src/tabs/color-page.css | 27 -- apps/ui/src/tabs/color-page.xml | 33 -- apps/ui/src/tabs/custom-tabstrip-page.css | 31 -- apps/ui/src/tabs/custom-tabstrip-page.ts | 22 -- apps/ui/src/tabs/custom-tabstrip-page.xml | 41 -- apps/ui/src/tabs/default-page.ts | 15 - apps/ui/src/tabs/default-page.xml | 89 ----- .../ui/src/tabs/dynamic-color-change-page.css | 28 -- apps/ui/src/tabs/dynamic-color-change-page.ts | 37 -- .../ui/src/tabs/dynamic-color-change-page.xml | 44 --- apps/ui/src/tabs/events-page.ts | 40 -- apps/ui/src/tabs/events-page.xml | 36 -- apps/ui/src/tabs/first-page.ts | 13 - apps/ui/src/tabs/first-page.xml | 7 - apps/ui/src/tabs/font-icons-page.css | 39 -- apps/ui/src/tabs/font-icons-page.xml | 63 --- apps/ui/src/tabs/font-page.css | 27 -- apps/ui/src/tabs/font-page.xml | 33 -- .../src/tabs/frame-in-tabs-inner-page-1.xml | 3 - .../src/tabs/frame-in-tabs-inner-page-2.xml | 3 - .../src/tabs/frame-in-tabs-inner-page-3.xml | 3 - .../src/tabs/frame-in-tabs-inner-page-4.xml | 3 - apps/ui/src/tabs/frame-in-tabs.ts | 3 - apps/ui/src/tabs/frame-in-tabs.xml | 24 -- apps/ui/src/tabs/highlight-color-page.css | 3 - apps/ui/src/tabs/highlight-color-page.xml | 24 -- apps/ui/src/tabs/icon-change-page.ts | 17 - apps/ui/src/tabs/icon-change-page.xml | 23 -- .../ui/src/tabs/icon-title-placement-page.xml | 30 -- apps/ui/src/tabs/issue-5470-page.xml | 27 -- apps/ui/src/tabs/item-color-page.css | 20 - apps/ui/src/tabs/item-color-page.xml | 40 -- apps/ui/src/tabs/main-page.ts | 38 -- apps/ui/src/tabs/main-page.xml | 6 - .../tabs/nested-bottom-navigation-page.xml | 39 -- apps/ui/src/tabs/nested-layout-page.xml | 26 -- apps/ui/src/tabs/reselect-page.ts | 68 ---- apps/ui/src/tabs/reselect-page.xml | 37 -- apps/ui/src/tabs/second-page.ts | 13 - apps/ui/src/tabs/second-page.xml | 7 - apps/ui/src/tabs/swipe-disabled-page.xml | 40 -- apps/ui/src/tabs/tab-strip-item-page.xml | 16 - apps/ui/src/tabs/tab-strip-items-page.xml | 88 ----- apps/ui/src/tabs/tabs-binding-page.ts | 6 - apps/ui/src/tabs/tabs-binding-page.xml | 17 - apps/ui/src/tabs/tabs-binding-view-model.ts | 59 --- apps/ui/src/tabs/tabs-page.ts | 15 - apps/ui/src/tabs/tabs-page.xml | 36 -- apps/ui/src/tabs/tabs-position-page.xml | 40 -- apps/ui/src/tabs/text-transform-page.css | 27 -- apps/ui/src/tabs/text-transform-page.xml | 33 -- packages/core/ui/index.ts | 1 - .../tab-strip-item/index.ts | 2 - 67 files changed, 4 insertions(+), 2881 deletions(-) delete mode 100644 apps/automated/src/ui/tabs/tabs-navigation-tests.ts delete mode 100644 apps/automated/src/ui/tabs/tabs-root-tests.ts delete mode 100644 apps/automated/src/ui/tabs/tabs-tests-native.android.ts delete mode 100644 apps/automated/src/ui/tabs/tabs-tests-native.d.ts delete mode 100644 apps/automated/src/ui/tabs/tabs-tests-native.ios.ts delete mode 100644 apps/automated/src/ui/tabs/tabs-tests-new.ts delete mode 100644 apps/automated/src/ui/tabs/tabs-tests.ts delete mode 100644 apps/ui/e2e/suites/tab-navigation/tabs/tabs-tests.e2e-spec.ts delete mode 100644 apps/ui/e2e/suites/tab-navigation/tabs/tabs-view-base-page.ts delete mode 100644 apps/ui/src/tabs/background-color-page.css delete mode 100644 apps/ui/src/tabs/background-color-page.xml delete mode 100644 apps/ui/src/tabs/color-page.css delete mode 100644 apps/ui/src/tabs/color-page.xml delete mode 100644 apps/ui/src/tabs/custom-tabstrip-page.css delete mode 100644 apps/ui/src/tabs/custom-tabstrip-page.ts delete mode 100644 apps/ui/src/tabs/custom-tabstrip-page.xml delete mode 100644 apps/ui/src/tabs/default-page.ts delete mode 100644 apps/ui/src/tabs/default-page.xml delete mode 100644 apps/ui/src/tabs/dynamic-color-change-page.css delete mode 100644 apps/ui/src/tabs/dynamic-color-change-page.ts delete mode 100644 apps/ui/src/tabs/dynamic-color-change-page.xml delete mode 100644 apps/ui/src/tabs/events-page.ts delete mode 100644 apps/ui/src/tabs/events-page.xml delete mode 100644 apps/ui/src/tabs/first-page.ts delete mode 100644 apps/ui/src/tabs/first-page.xml delete mode 100644 apps/ui/src/tabs/font-icons-page.css delete mode 100644 apps/ui/src/tabs/font-icons-page.xml delete mode 100644 apps/ui/src/tabs/font-page.css delete mode 100644 apps/ui/src/tabs/font-page.xml delete mode 100644 apps/ui/src/tabs/frame-in-tabs-inner-page-1.xml delete mode 100644 apps/ui/src/tabs/frame-in-tabs-inner-page-2.xml delete mode 100644 apps/ui/src/tabs/frame-in-tabs-inner-page-3.xml delete mode 100644 apps/ui/src/tabs/frame-in-tabs-inner-page-4.xml delete mode 100644 apps/ui/src/tabs/frame-in-tabs.ts delete mode 100644 apps/ui/src/tabs/frame-in-tabs.xml delete mode 100644 apps/ui/src/tabs/highlight-color-page.css delete mode 100644 apps/ui/src/tabs/highlight-color-page.xml delete mode 100644 apps/ui/src/tabs/icon-change-page.ts delete mode 100644 apps/ui/src/tabs/icon-change-page.xml delete mode 100644 apps/ui/src/tabs/icon-title-placement-page.xml delete mode 100644 apps/ui/src/tabs/issue-5470-page.xml delete mode 100644 apps/ui/src/tabs/item-color-page.css delete mode 100644 apps/ui/src/tabs/item-color-page.xml delete mode 100644 apps/ui/src/tabs/main-page.ts delete mode 100644 apps/ui/src/tabs/main-page.xml delete mode 100644 apps/ui/src/tabs/nested-bottom-navigation-page.xml delete mode 100644 apps/ui/src/tabs/nested-layout-page.xml delete mode 100644 apps/ui/src/tabs/reselect-page.ts delete mode 100644 apps/ui/src/tabs/reselect-page.xml delete mode 100644 apps/ui/src/tabs/second-page.ts delete mode 100644 apps/ui/src/tabs/second-page.xml delete mode 100644 apps/ui/src/tabs/swipe-disabled-page.xml delete mode 100644 apps/ui/src/tabs/tab-strip-item-page.xml delete mode 100644 apps/ui/src/tabs/tab-strip-items-page.xml delete mode 100644 apps/ui/src/tabs/tabs-binding-page.ts delete mode 100644 apps/ui/src/tabs/tabs-binding-page.xml delete mode 100644 apps/ui/src/tabs/tabs-binding-view-model.ts delete mode 100644 apps/ui/src/tabs/tabs-page.ts delete mode 100644 apps/ui/src/tabs/tabs-page.xml delete mode 100644 apps/ui/src/tabs/tabs-position-page.xml delete mode 100644 apps/ui/src/tabs/text-transform-page.css delete mode 100644 apps/ui/src/tabs/text-transform-page.xml diff --git a/apps/automated/src/test-runner.ts b/apps/automated/src/test-runner.ts index 015b82477..06d046475 100644 --- a/apps/automated/src/test-runner.ts +++ b/apps/automated/src/test-runner.ts @@ -200,15 +200,6 @@ export function isRunningOnEmulator(): boolean { // TODO: uncomment this // allTests["BOTTOM-NAVIGATION-NAVIGATION"] = bottomNavigationNavigationTests; - import * as tabsTests from './ui/tabs/tabs-tests'; - allTests['TABS'] = tabsTests; - - import * as tabsTestsNew from './ui/tabs/tabs-tests-new'; - allTests['TABS-NEW'] = tabsTestsNew; - - import * as tabsNavigationTests from './ui/tabs/tabs-navigation-tests'; - allTests['TABS-NAVIGATION'] = tabsNavigationTests; - import * as tabViewTests from './ui/tab-view/tab-view-tests'; allTests['TAB-VIEW'] = tabViewTests; diff --git a/apps/automated/src/ui/tabs/tabs-navigation-tests.ts b/apps/automated/src/ui/tabs/tabs-navigation-tests.ts deleted file mode 100644 index 44023ca28..000000000 --- a/apps/automated/src/ui/tabs/tabs-navigation-tests.ts +++ /dev/null @@ -1,284 +0,0 @@ -import * as TKUnit from '../../tk-unit'; -import * as helper from '../../ui-helper'; -import { Label } from '@nativescript/core/ui/label'; -import { StackLayout } from '@nativescript/core/ui/layouts/stack-layout'; -import { Frame } from '@nativescript/core/ui/frame'; -import { Page } from '@nativescript/core/ui/page'; -import { ListView, ItemEventData } from '@nativescript/core/ui/list-view'; -import { Tabs, TabContentItem, TabStrip, TabStripItem } from '@nativescript/core/ui/tabs'; -import { Button } from '@nativescript/core/ui/button'; - -var ASYNC = 2; - -function _createTabsNavigation(): Tabs { - var tabView = new Tabs(); - tabView.id = 'BottomNavigation'; - - return tabView; -} - -function _createContentItems(count: number): Array { - const items = new Array(); - for (let i = 0; i < count; i++) { - const label = new Label(); - label.text = 'Tab ' + i; - const tabEntry = new TabContentItem(); - tabEntry.content = label; - items.push(tabEntry); - } - - return items; -} - -function _createTabStrip(count: number): TabStrip { - const items = new Array(); - for (let i = 0; i < count; i++) { - let tabStripEntry = new TabStripItem(); - tabStripEntry.title = 'Tab ' + i; - items.push(tabStripEntry); - } - - const tabStrip = new TabStrip(); - tabStrip.items = items; - - return tabStrip; -} - -function _createListView(): ListView { - var listView = new ListView(); - listView.id = 'ListView'; - var items = Array.apply(null, Array(10)).map(function (_, i) { - return i; - }); - - listView.on(ListView.itemLoadingEvent, function (args: ItemEventData) { - var button =