javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-04 21:06:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

revert: perf(core): no need for batchUpdated if no selector (#9121)

Browse Source
This commit is contained in:
Igor Randjelovic
2021-02-04 22:03:56 +01:00
parent 6adcc40e25
commit 4b96d4baa0
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/core/ui/styling/style-scope.ts
View File

@ -473,7 +473,10 @@ export class CssState {
const matchingSelectors = this._match.selectors.filter((sel) => (sel.dynamic ? sel.match(view) : true)); const matchingSelectors = this._match.selectors.filter((sel) => (sel.dynamic ? sel.match(view) : true));
if (!matchingSelectors || matchingSelectors.length === 0) { if (!matchingSelectors || matchingSelectors.length === 0) {
return; // Ideally we should return here if there are no matching selectors, however
// if there are property removals, returning here would not remove them
// this is seen in STYLE test in automated.
// return;
} }
view._batchUpdate(() => { view._batchUpdate(() => {
this.stopKeyframeAnimations(); this.stopKeyframeAnimations();